New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862537 link

Starred by 2 users
Status: Fixed
Owner:
█ ichikawa@chromium.org
Last visit > 30 days ago
Closed: Jul 20
Cc:
ios-bugs@chromium.org
█ ichikawa@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Write integration tests for CWVWebView

Project Member Reported by ichikawa@google.com, Jul 11 
We already have some integration tests:
//ios/web_view/test
But they don't cover all methods in CWVWebView. We should write more tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/935b18d96ed2d628155c35e2969a981170bbdbcb

commit 935b18d96ed2d628155c35e2969a981170bbdbcb
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Tue Jul 17 03:05:34 2018

Add inttest for +[CWVWebView userAgentProduct]

Bug:  862537 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie69f12655aae22a9c48452d86ef27bafafadae68
Reviewed-on: https://chromium-review.googlesource.com/1132912
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575534}
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/BUILD.gn
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_autofill_inttest.mm
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_int_test.h
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_int_test.mm
[add] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_inttest.mm
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_kvo_inttest.mm
[modify] https://crrev.com/935b18d96ed2d628155c35e2969a981170bbdbcb/ios/web_view/test/web_view_script_command_inttest.mm
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d180a5b09ee45748e435769b9c497cf564a89b46

commit d180a5b09ee45748e435769b9c497cf564a89b46
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Thu Jul 19 01:00:49 2018

Add more integration tests for CWVWebView

Bug:  862537 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic60262906f269376375738afcf3067ee2d93294e
Reviewed-on: https://chromium-review.googlesource.com/1139945
Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576292}
[modify] https://crrev.com/d180a5b09ee45748e435769b9c497cf564a89b46/ios/web_view/test/web_view_inttest.mm
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20ad9fdd2418e0733f308d278830aac83f55ac49

commit 20ad9fdd2418e0733f308d278830aac83f55ac49
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Thu Jul 19 08:43:25 2018

Add inttest for CWVNavigationDelegate.

Bug:  862537 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9316b45024968ae37b51fe9547897f5e82a5d238
Reviewed-on: https://chromium-review.googlesource.com/1141553
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576422}
[modify] https://crrev.com/20ad9fdd2418e0733f308d278830aac83f55ac49/ios/web_view/test/BUILD.gn
[add] https://crrev.com/20ad9fdd2418e0733f308d278830aac83f55ac49/ios/web_view/test/navigation_delegate_inttest.mm
[modify] https://crrev.com/20ad9fdd2418e0733f308d278830aac83f55ac49/ios/web_view/test/web_view_inttest_base.mm
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/383f0038121fb7177222ee2bc68c7af9c9dc2377

commit 383f0038121fb7177222ee2bc68c7af9c9dc2377
Author: Hiroshi Ichikawa <ichikawa@chromium.org>
Date: Fri Jul 20 05:03:31 2018

Add inttest for CWVUIDelegate

Bug:  862537 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib7f92055fb4bdcf1b27b1801be2d6f1dad969282
Reviewed-on: https://chromium-review.googlesource.com/1143100
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576784}
[modify] https://crrev.com/383f0038121fb7177222ee2bc68c7af9c9dc2377/ios/web_view/test/BUILD.gn
[add] https://crrev.com/383f0038121fb7177222ee2bc68c7af9c9dc2377/ios/web_view/test/ui_delegate_inttest.mm
[modify] https://crrev.com/383f0038121fb7177222ee2bc68c7af9c9dc2377/ios/web_view/test/web_view_inttest_base.h
[modify] https://crrev.com/383f0038121fb7177222ee2bc68c7af9c9dc2377/ios/web_view/test/web_view_inttest_base.mm

Comment 5 by ichikawa@chromium.org, Jul 20

Status: Fixed (was: Started)
I believe I wrote integration tests for most part of CWVWebView. So let me close the bug. Let me know if I miss something.
►

Sign in to add a comment