Regression:Omnibox Focus Ring is not seen properly when dark theme is applied.
Reported by
shruti.j...@etouch.net,
Jul 11
|
||||||
Issue descriptionChrome Version: 69.0.3488.0 (Official Build) (cohort: Stable)Revision 8da4193c988f8252c21a1aace196644ab0929268-refs/branch-heads/3488@{#1}(64-bit) OS: Windows(7,8,8.1,10) and Linux(14.04 LTS) Test URL:https://chrome.google.com/webstore/detail/morpheon-dark/mafbdhjdkjnoafhfelkjpchpaepjknad?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome and Navigate to above URL and apply theme. 2.Click on Omnibox and observe Focus Ring on omnibox. Actual Result: Omnibox Focus Ring is not seen properly when dark theme is applied. Expected Result: Omnibox Focus Ring should be seen properly when dark theme is applied. This is a regression issue, broken in 'M-69', and below is bisect-info: Good Build:69.0.3486.0 (Revision: 573201) Bad Build: 69.0.3487.0 (Revision: 573574) Narrow Bisect info : (Unable to provide bisect using per-revision script,Hence providing bisect with old script): https://chromium.googlesource.com/chromium/src/+log/71ac85257f083f1d3ceded06f1d66992e033d389..5ca5adc6241adfee40346c44cf0f3e1d95769ad7 Suspecting: https://chromium.googlesource.com/chromium/src/+/332d32b73fe6367cc4fdf1baca9ac7909d3bbed5 @ Elly Fong-Jones : Could you please help to reassign if your change is not the cause for this change. Note :Pardon me if it is an intended as Focus Ring is very thin on omnibox and when dark theme is applied Focus Ring hides due to dark theme. Kindly refer the attached screen-cast. Thank You!
,
Jul 11
bklmn: any UX guidance on what would make sense here, visually?
,
Jul 12
,
Jul 13
Any conditional coloring based off themes is out of scope for 69. We don't do it today, so it's a feature request. Bumping to P3, removing "regression". If anyone disagrees please lmk, cc +lpalmaro as FYI in case you disagree.
,
Sep 20
,
Sep 26
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ellyjo...@chromium.org
, Jul 11