New issue
Advanced search Search tips

Issue 862518 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
Q2



Sign in to add a comment

Adaptive Toolbar: Change background color of the omnibox to be the same as the search button background

Project Member Reported by gambard@chromium.org, Jul 11

Issue description

See decription.
 
As the title says, the two should be in sync. Values are as follows:

Normal: black @ 0.09 alpha
Incognito: white @ 0.12 alpha
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f

commit d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f
Author: Gauthier Ambard <gambard@chromium.org>
Date: Wed Jul 11 12:52:53 2018

[iOS] Tweak location bar background color

This CL changes the location bar background to be less visible in
non-incognito. Also it updates the search button to be the same
background color as the location bar.

Bug:  862518 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7e25c2b093161524cb38619dcc834776e0891cc8
Reviewed-on: https://chromium-review.googlesource.com/1133008
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574134}
[modify] https://crrev.com/d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f/ios/chrome/browser/ui/toolbar/buttons/toolbar_configuration.mm
[modify] https://crrev.com/d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.h
[modify] https://crrev.com/d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f/ios/chrome/browser/ui/toolbar/buttons/toolbar_constants.mm
[modify] https://crrev.com/d3102f92ab1a35dce3ab5c3aa45b759f47a11f7f/ios/chrome/browser/ui/toolbar/buttons/toolbar_search_button.mm

Status: Fixed (was: Assigned)

Sign in to add a comment