New issue
Advanced search Search tips

Issue 862517 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jul 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Spinner keeps spinning even after search is finished.

Reported by pranjali...@etouch.net, Jul 11 
Chrome version : 69.0.3488.0 (Official Build) 8da4193c988f8252c21a1aace196644ab0929268-refs/branch-heads/3488@{#1}(32/64-bit) 

OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/'.
2. Type any alphabate in search box and observe.

Actual Result: Spinner keeps spinning even after search is finished.
Expected Result: Spinner should not keep spinning once search is finished.

This is a regression issue broken in ‘M-69’ and will below is bisect info.
Good build: 69.0.3487.0
Bad build: 69.0.3488.0
Actual_result.mp4
825 KB View Download
Expected_result.mp4
554 KB View Download

Comment 1 by pranjali...@etouch.net, Jul 11

Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)

You are probably looking for a change made after 573967 (known good), but no later than 573968 (first known bad).
CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b833f5b733ed26161ccffde48e1341528baf4f02..121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e

Suspect: https://chromium.googlesource.com/chromium/src/+/121ba4c5b400bbd3aaf4d0c5fb82f293f8091e0e

@dpapad: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Selection highlights in advanced setting remain even after search(i.e entered text) in search box is clear.

Comment 2 by dpa...@chromium.org, Jul 11 

I am able to reproduce this. Investigating...

Comment 3 by dpa...@chromium.org, Jul 11

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ab1508513baf70561ebe2289ca48030f3fca81a

commit 6ab1508513baf70561ebe2289ca48030f3fca81a
Author: dpapad <dpapad@chromium.org>
Date: Wed Jul 11 22:22:57 2018

Settings WebUI: Also look for no-search CSS attribute, if noSearch is false.

At r573968 the logic was modified to only look for the noSearch property for
subpage wrappers. It should also look for the CSS attribute for the case where
no-search is not part of a binding.

Bug:  862517 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id3f5dbcd86f931cce71f2e3c8a784780f5b34be6
Reviewed-on: https://chromium-review.googlesource.com/1133683
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574374}
[modify] https://crrev.com/6ab1508513baf70561ebe2289ca48030f3fca81a/chrome/browser/resources/settings/search_settings.js
[modify] https://crrev.com/6ab1508513baf70561ebe2289ca48030f3fca81a/chrome/test/data/webui/settings/search_settings_test.js

Comment 6 by dpa...@chromium.org, Jul 11

Status: Fixed (was: Started)
►

Sign in to add a comment