New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862514 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocked on:
issue 868442



Sign in to add a comment

Regression : Grey focus highlight seems to be shrink horizontally after hovering mouse on 'Avatar' icon near omnibox.

Reported by rp...@etouch.net, Jul 11

Issue description

Version: 69.0.3488.0 (Official Build)Revision 8da4193c988f8252c21a1aace196644ab0929268-refs/branch-heads/3488@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10) 

What steps will reproduce the problem?
1. Launch chrome,and change browser language to 'Hindi'
2. Now hover mouse over 'Avatar' icon and 'Customize and control Google Chrome' icon and observe grey focus highlight
 
Actual: Grey focus highlight seems to be shrink horizontally after hovering mouse
Expected: Grey focus highlight should be seen properly.

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3487.0  (Revision: 573575).
Bad build: 69.0.3488.0 (Revision: 574034).


 
Actual_video.mp4
267 KB View Download
Expected_video.mp4
254 KB View Download
Actual_screenshot.png
102 KB View Download
Expected_screenshot.png
103 KB View Download
Components: Blink
Labels: hasbisect
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 573749 (known good), but no later than 573757 (first known bad).

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/c7edc3debe8cfd6252336e7e8c2cc9a705d1ce53..6fcde312b4eebcbf61d171a855c36fa06d1a9fa7?pretty=fuller&n=50

Suspecting: r573752 from Narrow bisect

@pbos: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Unable to provide bisect using per-revision script,Hence providing chromium bisect.
2.Issue is not seen on Mac(10.12.6,10.13.1,10.13.6)& Linux (14.04 LTS)OS
Components: -Blink UI>Browser
Labels: Proj-MdRefresh
Labels: Group-Avatar_Button
Cc: pbos@chromium.org
Owner: bsep@chromium.org
Load balancing.
Labels: -Pri-1 Pri-3 Hotlist-Polish
Status: Available (was: Assigned)
Labels: -Pri-3 Pri-2
Status: Assigned (was: Available)
This is pretty bad for these languages, bumping prio as I don't think we should ship this bug. LMK if you disagree.
Cc: bsep@chromium.org
Owner: pbos@chromium.org
Load balancing
Components: -UI>Localization
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6a591e5c36e920725061d60f71bc5e3005d0fe

commit fc6a591e5c36e920725061d60f71bc5e3005d0fe
Author: Peter Boström <pbos@chromium.org>
Date: Thu Jul 26 18:53:04 2018

Fixate toolbar button font height

This fixes an issue where Hindi increases ToolbarButton's height
resulting in oblong InkDrop shapes. It also increases the font size for
touchable Chrome which matches the larger shape of the toolbar better.

Bug:  chromium:862514 
Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8
Reviewed-on: https://chromium-review.googlesource.com/1150960
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578385}
[modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/chrome_typography.cc
[modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/chrome_typography.h
[modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/harmony_typography_provider.cc
[modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/toolbar/toolbar_button.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M70 TE-Verified-70.0.3504.0
Update :
Rechecked the above issue on Windows(7,8,8.1,10)OS with latest Canary Chrome version : 70.0.3504.0 and the issue is Fixed.Hence adding TE Verified Label.

Kindly refer the attached screen cast for reference.
Fixed_video.mp4
294 KB View Download
Labels: Merge-Request-69
Status: Verified (was: Fixed)
Thanks!

Requesting merge to M69, this is a pretty significant visual regression for a large population (Hindi, languages with other taller fonts).
Blockedon: 868442
There is probably a regression:  Issue 868442 
Labels: -Merge-Request-69
Status: Started (was: Verified)
Removing merge-request until we've fixed the fix. Thanks mehmet@.
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26

commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26
Author: Peter Boström <pbos@chromium.org>
Date: Sun Jul 29 06:28:15 2018

Decrease available ToolbarButton height for font

The current 18dp fixed height results in pushing the total button height
on Mac. This doesn't happen by default on Windows as the default font
results in equal size_delta values for 18dp and 17dp available height.

This probably means that 17dp is the actual available height that
doesn't increase the toolbar-button height.

Bug:  chromium:862514 ,  chromium:868442 
Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3
Reviewed-on: https://chromium-review.googlesource.com/1153574
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578947}
[modify] https://crrev.com/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26/chrome/browser/ui/views/harmony/chrome_typography.cc

Labels: TE-Verified-70.0.3507.0
Update :
Rechecked the above issue on Windows(7,8,8.1,10) OS with latest Canary Chrome version : 70.0.3507.0 and the issue is Fixed.Hence adding TE Verified Label.

Kindly refer the attached screen cast for reference.
Fixed_video.mp4
282 KB View Download
Labels: Merge-Request-69
Requesting merge, comment #13 still applies, we just need to apply both patches.
Status: Verified (was: Started)
Labels: -Merge-Request-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #19. Please merge. Thank you.
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac5a8875e9955625371f4a42b44aa3a43ba6699

commit eac5a8875e9955625371f4a42b44aa3a43ba6699
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 23:23:37 2018

Fixate toolbar button font height

This fixes an issue where Hindi increases ToolbarButton's height
resulting in oblong InkDrop shapes. It also increases the font size for
touchable Chrome which matches the larger shape of the toolbar better.

Bug:  chromium:862514 
Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8
Reviewed-on: https://chromium-review.googlesource.com/1150960
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578385}(cherry picked from commit fc6a591e5c36e920725061d60f71bc5e3005d0fe)
Reviewed-on: https://chromium-review.googlesource.com/1155499
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#253}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/chrome_typography.cc
[modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/chrome_typography.h
[modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/harmony_typography_provider.cc
[modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/toolbar/toolbar_button.cc

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5

commit e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5
Author: Peter Boström <pbos@chromium.org>
Date: Mon Jul 30 23:24:01 2018

Decrease available ToolbarButton height for font

The current 18dp fixed height results in pushing the total button height
on Mac. This doesn't happen by default on Windows as the default font
results in equal size_delta values for 18dp and 17dp available height.

This probably means that 17dp is the actual available height that
doesn't increase the toolbar-button height.

Bug:  chromium:862514 ,  chromium:868442 
Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3
Reviewed-on: https://chromium-review.googlesource.com/1153574
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578947}(cherry picked from commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26)
Reviewed-on: https://chromium-review.googlesource.com/1155617
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#254}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5/chrome/browser/ui/views/harmony/chrome_typography.cc

Labels: TE-Verified-69.0.3497.23 TE-Verified-M69
Update :
Rechecked the above issue on Windows(7,8,8.1,10) OS using Dev build version : 69.0.3497.23 and the issue is Fixed.Hence adding TE Verified Label.

Kindly refer the attached screen cast for reference.
Fixed_video.mp4
448 KB View Download
Cc: abdulsyed@chromium.org
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh .

Sign in to add a comment