Issue metadata
Sign in to add a comment
|
Regression : Grey focus highlight seems to be shrink horizontally after hovering mouse on 'Avatar' icon near omnibox.
Reported by
rp...@etouch.net,
Jul 11
|
||||||||||||||||||||||
Issue descriptionVersion: 69.0.3488.0 (Official Build)Revision 8da4193c988f8252c21a1aace196644ab0929268-refs/branch-heads/3488@{#1}(32/64-bit) OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome,and change browser language to 'Hindi' 2. Now hover mouse over 'Avatar' icon and 'Customize and control Google Chrome' icon and observe grey focus highlight Actual: Grey focus highlight seems to be shrink horizontally after hovering mouse Expected: Grey focus highlight should be seen properly. This is regression issue, broken in ‘M 69’ and will soon update other info : Good build: 69.0.3487.0 (Revision: 573575). Bad build: 69.0.3488.0 (Revision: 574034).
,
Jul 12
,
Jul 12
,
Jul 12
,
Jul 16
Load balancing.
,
Jul 17
,
Jul 17
This is pretty bad for these languages, bumping prio as I don't think we should ship this bug. LMK if you disagree.
,
Jul 23
Load balancing
,
Jul 23
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc6a591e5c36e920725061d60f71bc5e3005d0fe commit fc6a591e5c36e920725061d60f71bc5e3005d0fe Author: Peter Boström <pbos@chromium.org> Date: Thu Jul 26 18:53:04 2018 Fixate toolbar button font height This fixes an issue where Hindi increases ToolbarButton's height resulting in oblong InkDrop shapes. It also increases the font size for touchable Chrome which matches the larger shape of the toolbar better. Bug: chromium:862514 Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8 Reviewed-on: https://chromium-review.googlesource.com/1150960 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578385} [modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/fc6a591e5c36e920725061d60f71bc5e3005d0fe/chrome/browser/ui/views/toolbar/toolbar_button.cc
,
Jul 26
,
Jul 27
Update : Rechecked the above issue on Windows(7,8,8.1,10)OS with latest Canary Chrome version : 70.0.3504.0 and the issue is Fixed.Hence adding TE Verified Label. Kindly refer the attached screen cast for reference.
,
Jul 27
Thanks! Requesting merge to M69, this is a pretty significant visual regression for a large population (Hindi, languages with other taller fonts).
,
Jul 27
,
Jul 27
There is probably a regression: Issue 868442
,
Jul 27
Removing merge-request until we've fixed the fix. Thanks mehmet@.
,
Jul 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26 commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26 Author: Peter Boström <pbos@chromium.org> Date: Sun Jul 29 06:28:15 2018 Decrease available ToolbarButton height for font The current 18dp fixed height results in pushing the total button height on Mac. This doesn't happen by default on Windows as the default font results in equal size_delta values for 18dp and 17dp available height. This probably means that 17dp is the actual available height that doesn't increase the toolbar-button height. Bug: chromium:862514 , chromium:868442 Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3 Reviewed-on: https://chromium-review.googlesource.com/1153574 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578947} [modify] https://crrev.com/0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26/chrome/browser/ui/views/harmony/chrome_typography.cc
,
Jul 30
Update : Rechecked the above issue on Windows(7,8,8.1,10) OS with latest Canary Chrome version : 70.0.3507.0 and the issue is Fixed.Hence adding TE Verified Label. Kindly refer the attached screen cast for reference.
,
Jul 30
Requesting merge, comment #13 still applies, we just need to apply both patches.
,
Jul 30
,
Jul 30
Approving merge to M69 branch 3497 based on comment #19. Please merge. Thank you.
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eac5a8875e9955625371f4a42b44aa3a43ba6699 commit eac5a8875e9955625371f4a42b44aa3a43ba6699 Author: Peter Boström <pbos@chromium.org> Date: Mon Jul 30 23:23:37 2018 Fixate toolbar button font height This fixes an issue where Hindi increases ToolbarButton's height resulting in oblong InkDrop shapes. It also increases the font size for touchable Chrome which matches the larger shape of the toolbar better. Bug: chromium:862514 Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8 Reviewed-on: https://chromium-review.googlesource.com/1150960 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578385}(cherry picked from commit fc6a591e5c36e920725061d60f71bc5e3005d0fe) Reviewed-on: https://chromium-review.googlesource.com/1155499 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#253} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/chrome_typography.cc [modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/chrome_typography.h [modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/harmony/harmony_typography_provider.cc [modify] https://crrev.com/eac5a8875e9955625371f4a42b44aa3a43ba6699/chrome/browser/ui/views/toolbar/toolbar_button.cc
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5 commit e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5 Author: Peter Boström <pbos@chromium.org> Date: Mon Jul 30 23:24:01 2018 Decrease available ToolbarButton height for font The current 18dp fixed height results in pushing the total button height on Mac. This doesn't happen by default on Windows as the default font results in equal size_delta values for 18dp and 17dp available height. This probably means that 17dp is the actual available height that doesn't increase the toolbar-button height. Bug: chromium:862514 , chromium:868442 Change-Id: I7c07eb987cb5e4f7a0f200dcbe77b2ac72a751f3 Reviewed-on: https://chromium-review.googlesource.com/1153574 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578947}(cherry picked from commit 0cdb7dd4de9d13ce3b5f74e39d47f96bd2383a26) Reviewed-on: https://chromium-review.googlesource.com/1155617 Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#254} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/e4961c5b9c0c61e3ffbc65c6ef87d897ea0f28c5/chrome/browser/ui/views/harmony/chrome_typography.cc
,
Aug 1
Update : Rechecked the above issue on Windows(7,8,8.1,10) OS using Dev build version : 69.0.3497.23 and the issue is Fixed.Hence adding TE Verified Label. Kindly refer the attached screen cast for reference.
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rp...@etouch.net
, Jul 11Labels: hasbisect
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)