New issue
Advanced search Search tips

Issue 862505 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: PictureInPictureWindowControllerBrowserTest.SurfaceIdChangeDoesNotMoveWindow



Sign in to add a comment

PictureInPictureWindowControllerBrowserTest.SurfaceIdChangeDoesNotMoveWindow is Flaky

Project Member Reported by Findit, Jul 11

Issue description

Owner: blundell@chromium.org
Status: Started (was: Available)
Revert is out in https://chromium-review.googlesource.com/c/chromium/src/+/1132978.
Components: Blink>Media>PictureInPicture
Owner: mlamouri@chromium.org
Uploading a CL to disable the test: https://chromium-review.googlesource.com/c/chromium/src/+/1133306
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e73dbe75e32793f9eee2fd0a6ec08a50792d0e8

commit 4e73dbe75e32793f9eee2fd0a6ec08a50792d0e8
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Jul 11 15:49:16 2018

Picture-in-Picture: disabling flaky tests while origin is investigated.

Bug:  862505 
Change-Id: I1bcb2019be64dbb91081e1f8d607aca4cb0fbdc5
TBR: apacible@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1133306
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574176}
[modify] https://crrev.com/4e73dbe75e32793f9eee2fd0a6ec08a50792d0e8/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Labels: -Sheriff-Chromium
Labels: -Pri-1 Pri-2
Cc: mlamouri@chromium.org
Owner: fbeaufort@chromium.org
I'm going to re-enable this test on all platforms to see if it is still flaky.
See https://chromium-review.googlesource.com/c/chromium/src/+/1243083
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/644556f5c135a5aeb14107f7915475dc21ca0bd9

commit 644556f5c135a5aeb14107f7915475dc21ca0bd9
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 25 15:54:36 2018

Re-enable flaky test SurfaceIdChangeDoesNotMoveWindow.

Now that SetAspectRatio is implemented everywhere, this CL re-enables a
PictureInPictureWindowControllerBrowserTest test which was found flaky
previously.

Bug:  862505 
Change-Id: I884a1b1ff3fe131c671c5e1a5e8142bb5e7d9a8a
Reviewed-on: https://chromium-review.googlesource.com/1243083
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#593950}
[modify] https://crrev.com/644556f5c135a5aeb14107f7915475dc21ca0bd9/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

I didn't find any flakyness so I think we're good.

Sign in to add a comment