New issue
Advanced search Search tips

Issue 862504 link

Starred by 1 user
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Jul 12
Cc:
omrilio@chromium.org
dtseng@chromium.org
lpalmaro@chromium.org
yamaguchi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Unified System Tray - Detailed view does not get focus on ChromeVox

Project Member Reported by tetsui@chromium.org, Jul 11 
Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Enable ChromeVox
(2) Open system tray by Alt-Shift-S
(3) Tab to the Bluetooth button and hit enter.

What is the expected result?
It should focus to the detailed view contents.

What happens instead?
The entire bubble takes the focus.

Comment 1 by tetsui@chromium.org, Jul 11

Status: Started (was: Assigned)
https://crrev.com/c/1132899
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/704db340a765dc9972c0018b74fbb2908cb04d0c

commit 704db340a765dc9972c0018b74fbb2908cb04d0c
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Thu Jul 12 02:06:55 2018

Unified: Get default focus on detailed view.

In UnifiedSystemTray, detailed view did not get focus when it is
transitioned by keyboard.

TEST=manual
BUG= 862504 

Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
Reviewed-on: https://chromium-review.googlesource.com/1132899
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574461}
[modify] https://crrev.com/704db340a765dc9972c0018b74fbb2908cb04d0c/ash/system/tray/tray_detailed_view.cc
[modify] https://crrev.com/704db340a765dc9972c0018b74fbb2908cb04d0c/ash/system/tray/tray_detailed_view.h
[modify] https://crrev.com/704db340a765dc9972c0018b74fbb2908cb04d0c/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/704db340a765dc9972c0018b74fbb2908cb04d0c/ash/system/unified/unified_system_tray_view.cc

Comment 3 by tetsui@chromium.org, Jul 12

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1af79c35e1a0c236c2f0eab00e0669efb38d6d8

commit e1af79c35e1a0c236c2f0eab00e0669efb38d6d8
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Mon Jul 30 10:57:51 2018

Revert "Unified: Get default focus on detailed view."

This reverts commit 704db340a765dc9972c0018b74fbb2908cb04d0c.

Reason for revert: Crash https://crbug.com/868059

Original change's description:
> Unified: Get default focus on detailed view.
> 
> In UnifiedSystemTray, detailed view did not get focus when it is
> transitioned by keyboard.
> 
> TEST=manual
> BUG= 862504 
> 
> Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad
> Reviewed-on: https://chromium-review.googlesource.com/1132899
> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574461}

TBR=yoshiki@chromium.org,tetsui@chromium.org,sammiequon@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  862504 ,868059
Change-Id: Iaf2f70f3b22a21a3e18863ad1911fca7772c3b63
Reviewed-on: https://chromium-review.googlesource.com/1154568
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579006}
[modify] https://crrev.com/e1af79c35e1a0c236c2f0eab00e0669efb38d6d8/ash/system/tray/tray_detailed_view.cc
[modify] https://crrev.com/e1af79c35e1a0c236c2f0eab00e0669efb38d6d8/ash/system/tray/tray_detailed_view.h
[modify] https://crrev.com/e1af79c35e1a0c236c2f0eab00e0669efb38d6d8/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/e1af79c35e1a0c236c2f0eab00e0669efb38d6d8/ash/system/unified/unified_system_tray_view.cc
►

Sign in to add a comment