New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862482 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression in 67.0.3396.33 special characters instead numbers when using on-screen keyboard

Project Member Reported by marchuk@chromium.org, Jul 11

Issue description

ChromeOS version: 67.0.3396.33
ChromeOS device model: any
Case#: 16322393 

Description:
When using the on-screen keyboard, after clicking on a field to type characters, the first entered character uses the "shift" value.

Steps to reproduce: 
1. Enable on-screen keyboard in accessibility.
2. Start typing numbers in addressbar using on-screen keyboard 
3. Click on addressbar once
4. Click on any number

Current Behavior / Reproduction: 
as in bad_67.0.3396.33.webm
Special character is entered (e.g. "@" instead of "2")

Expected Behavior: 
as in good_67.0.3396.31.webm
Number is entered (e.g. "2" but not "@")

I can always reproduce it and bisected it to range, but cannot find even rough suspect:
Last known good: 67.0.3396.31
First known bad: 67.0.3396.33

https://chromium.googlesource.com/chromium/src/+log/67.0.3396.31..67.0.3396.33?n=10000
 
bad_67.0.3396.33.webm
7.1 MB View Download
Cc: marchuk@google.com
good_67.0.3396.31.webm
3.4 MB View Download
Owner: iloahz@chromium.org
The regression likely came in a Chrome OS change, not browser. The equivalent changelog for Chrome OS is:

https://crosland.corp.google.com/log/10575.25.0..10575.28.0

which has:

https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/ec175d069a80d932f566f1c397cbfa246911ea1d#

"[IME] Update to 67.0.0.1" touches on virtual keyboard.

+ Li can yo take a look at this regression?
Status: Assigned (was: Untriaged)
Hi all,

Do we have any updates on this issue? Is there something we can gather additionally via the technical cases to help with the investigation?

Thanks!
Labels: -Pri-2 Pri-1
Raising priority on this as it's directly impacting a significant enterprise customer.

@Li: please provide us with some update ASAP. Thanks.
Hi all,

I'm able to reproduce the behavior on 68.0.3440.76
Labels: ReleaseBlock-Stable
[flagging for review by TPM team]
Labels: M-68
Cc: cvintila@chromium.org
fixed in google3, will do a release on M68 to land the fix.
Labels: Merge-Request-68
Labels: -ReleaseBlock-Stable
This shows existing in 67, it will not block stable, as it is not a regression.

What CL goes into Chrome OS to fix this, is there a branch of the G3 code that gets integrated into CrOS somehow?
Labels: -Merge-Request-68 Merge-Approved-68
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 7

Labels: merge-merged-release-R68-10718.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/4329eab1321aa67aa2dfcc4a29d57d6214fd8ea6

commit 4329eab1321aa67aa2dfcc4a29d57d6214fd8ea6
Author: Chen Gong <chengong@google.com>
Date: Tue Aug 07 01:04:17 2018

Project Member

Comment 15 by sheriffbot@chromium.org, Aug 10

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 13

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-68 M-69 Merge-Request-69
looks like this is done for 68 (can someone confirm?)

Still needs to be merged to 69 afaik though.
Project Member

Comment 18 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Could you tell us which versions should have this fix? I have contradicting reports - our Buddy on 10718.71.2 stable still reproduces the issue, but customer says that Eve on 10718.71.2 Beta doesn't. Maybe this fix was pushed only for some of devices?
It's landed first on 10718.77.0, which seems not pushed yet.
This bug has a target milestone that has passed.  Please help bug cleanup: mark it closed or update/remove the milestone target. 
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/a07da01b7c5a736be9b4dc47f30cd1030b34c721

commit a07da01b7c5a736be9b4dc47f30cd1030b34c721
Author: Darren Shen <shend@google.com>
Date: Wed Aug 22 02:27:49 2018

Status: Fixed (was: Assigned)
Hi @vkhabarov,

could you help confirm the fix?
Hi @iloahz,
I've checked on our test device and it seems to be fixed with latest stable, checking with customer. Might take a while because of ARC++ devices delay
thank you @vkhabarov!
Cc: shend@chromium.org yhanada@chromium.org
 Issue 867001  has been merged into this issue.

Sign in to add a comment