New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862480 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 26
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

network-summary-items failing to route

Project Member Reported by jordynass@chromium.org, Jul 11

Issue description

I noticed a bug in an in-progress CL (https://chromium-review.googlesource.com/c/chromium/src/+/1132618) just after my previous CL merged (https://chromium-review.googlesource.com/c/chromium/src/+/1128334). The most obvious problem was that when I hit the Ethernet network-summary-item's subpage arrow, it repeatedly took me to an 'Aw Snap' error page. It also stopped recognizing a nearby phone that it had been before, although the phone was crashing a little so that might be unrelated.

I assumed either my in progress CLs (the one above and another related one) or my recently merged CL was responsible, but I checked out the parent of my submitted CL and had the same problems after running the following from the parent:

gclient sync
gn gen out_${SDK_BOARD}/Release --args="$GN_ARGS is_component_build=false is_official_build=true google_api_key = \"AIzaSyB5xPRa167froOkV6d90414y0ETWm1PQkU\"
google_default_client_id = \"1005135349943.apps.googleusercontent.com\"
google_default_client_secret = \"hnK2HogwFa3XlWsMuBaUpp6D\" dcheck_always_on = true"
cros chrome-sdk --board=eve
~/goma/goma_ctl.py ensure_start
autoninja -C out_eve/Release chrome
gn args out_eve/Release
deploy_chrome --build-dir=out_eve/Release --to=<my device>

 
Cc: khorimoto@chromium.org
You could try reverting your previous change or rolling back before then to verify it isn't your change. You should also verify whether it can be reproduced without tethering a device; if not, please assign this to khorimoto@ instead.

This sounds like a render crash. You should look at the chrome logs to see if there are any FATAL messages.

I will see if I can reproduce it locally with a ToT build (without a tethered device).

Labels: -Pri-3 Pri-1
khorimoto@ says he deployed a ToT build from his machine and didn't see the bug so my guess is I accidentally messed with something subtle in the background when I was working on the internet folder. All of that work is local so if it's working for stevenjb@, I will try just deleting the whole out folder and running ToT. If that doesn't repro the problem, I think it's safe to say it's just an issue with my local branch so I'll close this bug and get back to debugging my branch.
Note: khorimoto@ only checked the Ethernet network-summary-item, but I think there's a good chance the other problem will either be gone when the Ethernet item works or else is due to the phone. Either way, I think we can ignore it here.
Cc: steve...@chromium.org
Owner: jordynass@chromium.org
Status: Assigned (was: Untriaged)
You shouldn't need to delete your 'out' folder, you should just be able to check out 'master' and rebuild.

Assigning back to you to further investigate.

(Oh, and to confirm, I'm not seeing any issues on a ToT build locally, without a tethered device).

In my rush to write up the bug, I skipped over the fact that I had run from ToT before I tried a parent of my change. That's why I'm trying more dramatic steps.
Status: WontFix (was: Assigned)

Sign in to add a comment