WebUI Polymer 2: Add a runtime flag that makes WebUI use Polymer 2. |
||||||
Issue descriptionAfter some thinking about how to roll out Polymer 2, I am leaning towards the following approach: 1) Add Polymer 2 in third_party/polymer, side-by-side with Polymer 1. 2) Use a Finch flag Polymer2WebUI (disabled by default) to make the code use Polymer2 3) Add a new set of browser_tests that runs on the bots with Polymer 2 enabled (see CL at [1]). Failing tests will be excluded with a filter initially, and will be included as they are fixed. 4) Once all automated tests pass, make Polymer2WebUI enabled by default. Pros: The runtime flag provides great flexibility. - Ability to revert to Polymer 1 via Finch, if necessary. - Ability to continuously test both Polymer 1 and Polymer 2. This guarantees that when we fix something for Polymer 2, it does not get broken again, before we fully roll out Polymer 2. Cons: Adds additional size to the binary. Need to evaluate exactly how much. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1132320
,
Jul 11
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4712adb2380abb815e6b0c49946e0b3000482c85 commit 4712adb2380abb815e6b0c49946e0b3000482c85 Author: dpapad <dpapad@chromium.org> Date: Wed Jul 11 21:50:30 2018 WebUI Polymer: Use .bowerrc ignoreDependencies. Instead of downloading unnecessary dependencies, and then deleting them within reproduce.sh, use bower's ignoreDependencies feature. This has the advantage of skipping downloading, as well as skipping dependency version checks. The latter is necessary to have both Polymer 1 and Polymer 2 temporarily side by side, otherwise there is a dependency conflict for webcomponentsjs. Bug: 862472 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1ddd50f55dd3598d7886aa72c731b49a25eb53cc Reviewed-on: https://chromium-review.googlesource.com/1132628 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#574352} [delete] https://crrev.com/d8362eae96c767c2bda4a6d192e7206666820c1d/third_party/polymer/.bowerrc [add] https://crrev.com/4712adb2380abb815e6b0c49946e0b3000482c85/third_party/polymer/v1_0/.bowerrc [modify] https://crrev.com/4712adb2380abb815e6b0c49946e0b3000482c85/third_party/polymer/v1_0/reproduce.sh
,
Jul 13
Should we rename the "v1_0" directory to "src" or "polymer" or something?
,
Jul 13
That sounds like a good idea, although I don't think is urgent. Maybe we can leave this for later, after the dust from the migration settles, to avoid churn?
,
Jul 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ff813fa96108e9f9cc7474bee47fda0fccd20ca commit 5ff813fa96108e9f9cc7474bee47fda0fccd20ca Author: dpapad <dpapad@chromium.org> Date: Sat Jul 14 02:26:49 2018 WebUI: Add Polymer 2 to third_party/polymer - Update reproduce.sh as necessary. - Add python script to minify Polymer 2 since it does not come minified from bower, unlike Polymer 1. Minified version is 135kb (pre-gzip), which is smaller than Polymer 1 (220kb). - grd files will be modified in follow up CLs, along with the addition of the runtime flag. Bug: 862472 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2d084e9ee37c419175831ff64694f47ea277bba Reviewed-on: https://chromium-review.googlesource.com/1132478 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575134} [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/README.chromium [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/PRESUBMIT.py [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/bower.json [add] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/components-chromium/polymer2/LICENSE.txt [add] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/components-chromium/polymer2/bower.json [add] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/components-chromium/polymer2/polymer-extracted.js [add] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/components-chromium/polymer2/polymer.html [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/extract_inline_scripts.py [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/find_unused_elements.py [add] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/minify_polymer.py [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/reproduce.sh [modify] https://crrev.com/5ff813fa96108e9f9cc7474bee47fda0fccd20ca/third_party/polymer/v1_0/rsync_exclude.txt
,
Jul 14
WIP CL for adding the runtime flag is at https://chromium-review.googlesource.com/c/chromium/src/+/1137706.
,
Jul 16
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2313a4f9f4a5896d7116f889146489c48685bae4 commit 2313a4f9f4a5896d7116f889146489c48685bae4 Author: dpapad <dpapad@chromium.org> Date: Tue Jul 17 17:03:09 2018 WebUI: Add kWebUIPolymer2 runtime flag. When the flag is on, Polymer 2 is used everywhere. When off, Polymer 1 is used. Bug: 862472 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iefdbf6448c0c69b6f22df1a3db57db29e29607da Reviewed-on: https://chromium-review.googlesource.com/1137706 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#575688} [modify] https://crrev.com/2313a4f9f4a5896d7116f889146489c48685bae4/content/browser/webui/shared_resources_data_source.cc [modify] https://crrev.com/2313a4f9f4a5896d7116f889146489c48685bae4/content/public/common/content_features.cc [modify] https://crrev.com/2313a4f9f4a5896d7116f889146489c48685bae4/content/public/common/content_features.h [modify] https://crrev.com/2313a4f9f4a5896d7116f889146489c48685bae4/ui/webui/resources/polymer_resources.grdp
,
Jul 27
--enable-features=WebUIPolymer2 has been added, but currently only works with optimize_webui=false. Adding related bug as blocker.
,
Jul 28
Status update: The candidate CL that makes --enable-features=WebUIPolymer2 and optimize_webui=true work together is at https://chromium-review.googlesource.com/c/chromium/src/+/1154192.
,
Jul 30
Remaining tasks divided in 4 CLs: 1) Update optimize_webui.py/gni, https://chromium-review.googlesource.com/c/chromium/src/+/1155474 2) Make WebUIPolymer2 flag work part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1155481 3) Make WebUIPolymer2 flag work part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1155827 4) Make WebUIPolymer2 flag work part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1155834
,
Jul 31
Is this migration targeted for completion by M70 branch, or will both versions live side-by-side in M70 stable? Now that you have several CLs out, I'd be interested in seeing the total binary size difference in an official build.
,
Jul 31
Updated the parent bug to indicate the target milestone, which is M71 (also mentioned at the Polymer 2 migration update at [1] (internal only). I will measure the size difference as a result of including both P1 and P2 bundles and post in this bug. I am also expecting this to have a minimal effect post-gzip since a lot of the content between the P1 and P2 HTML bundles is identical. Do you think it would be worth doing this only for non-official build for now, that the M70 stable binary size stays unaffected, while still allowing developers to try their code with Polymer 2 to fix issues locally? I could look into that if that's important. [1] https://groups.google.com/a/google.com/d/msg/chrome-webui/_BtqV6aErFA/N8l7jiU5AAAJ
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13db9f604c3a9432b3f83c685103f52bfb2e9a58 commit 13db9f604c3a9432b3f83c685103f52bfb2e9a58 Author: dpapad <dpapad@chromium.org> Date: Tue Jul 31 18:55:41 2018 WebUI: Update optimize_webui.py/gni to support Polymer 2 HTML bundles. - Add a new html_out_files_polymer2 optional parameter. - When specified, causes both the Polymer 1 and Polymer 2 HTML bundles to be generated. The parameter will be used in follow-up CLs. Bug: 862472 Change-Id: Iaa015d3cc7091b1b2f4e84aa36fae7b039b58846 Reviewed-on: https://chromium-review.googlesource.com/1155474 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579504} [modify] https://crrev.com/13db9f604c3a9432b3f83c685103f52bfb2e9a58/chrome/browser/resources/optimize_webui.gni [modify] https://crrev.com/13db9f604c3a9432b3f83c685103f52bfb2e9a58/chrome/browser/resources/optimize_webui.py [modify] https://crrev.com/13db9f604c3a9432b3f83c685103f52bfb2e9a58/chrome/browser/resources/optimize_webui_test.py
,
Jul 31
> I will measure the size difference as a result of including both P1 and P2 bundles and post in this bug. Measured the size of resources.pak in the output directory (which includes all WebUI code) Desktop Linux 12432 bytes -> 12684 bytes, 1.99% increase ChromeOS (on Linux) 30828 bytes -> 30492 bytes, 1.09% increase
,
Jul 31
> ChromeOS (on Linux) > 30828 bytes -> 30492 I accidentally reversed the numbers here. Correcting: 30492 bytes -> 30828 bytes, 1.09% increase
,
Jul 31
Wait, so including polymer2 vulcanized versions of these WebUI resources really only adds a couple hundred bytes? (I guess the files are mostly identical, and de-duped during compression, but still surprising.)
,
Jul 31
Yes, it is a bit surprising. Either way, I double checked that resources.pak is the correct file to meauser, see the code at [1] which compbines all other temporary pak files into the final resources.pak below. https://cs.chromium.org/chromium/src/chrome/chrome_paks.gni?l=90-106
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d216aa25d0cf1ebc2caac86ceea97aeb0722a594 commit d216aa25d0cf1ebc2caac86ceea97aeb0722a594 Author: dpapad <dpapad@chromium.org> Date: Wed Aug 01 00:18:55 2018 WebUI: Make WebUIPolymer2 flag work for optimize_webui=true, part 1. In this CL updating: - chrome://bluetooth-pairing - chrome://internet-config-dialog - chrome://internet-detail-dialog This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: I39b28ab6ede92c37092184b5480bafb239844628 Reviewed-on: https://chromium-review.googlesource.com/1155481 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579632} [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/browser_resources.grd [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/resources/chromeos/bluetooth_pairing_dialog/BUILD.gn [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/resources/chromeos/internet_config_dialog/BUILD.gn [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/resources/chromeos/internet_detail_dialog/BUILD.gn [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/chrome/browser/ui/webui/chromeos/internet_detail_dialog.cc [modify] https://crrev.com/d216aa25d0cf1ebc2caac86ceea97aeb0722a594/tools/gritsettings/resource_ids
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/274bfa5ec8853bfa1232259e8f45a47be4ac206c commit 274bfa5ec8853bfa1232259e8f45a47be4ac206c Author: dpapad <dpapad@chromium.org> Date: Wed Aug 01 01:36:00 2018 WebUI: Make WebUIPolymer2 flag work for optimize_webui=true, part 2. In this CL updating: - chrome://bookmarks - chrome://downloads - chrome://extensions This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: I55e0edbd4e9269432e2494aadb3d0abae146b43b Reviewed-on: https://chromium-review.googlesource.com/1155827 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579661} [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/browser_resources.grd [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/resources/md_bookmarks/BUILD.gn [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/resources/md_downloads/BUILD.gn [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/resources/md_extensions/BUILD.gn [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/resources/md_extensions/extensions_resources_vulcanized.grd [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/ui/webui/extensions/extensions_ui.cc [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/274bfa5ec8853bfa1232259e8f45a47be4ac206c/chrome/browser/ui/webui/md_downloads/md_downloads_ui.cc
,
Aug 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27176197c23ea72e3f1ebfeb1d928f961da399e2 commit 27176197c23ea72e3f1ebfeb1d928f961da399e2 Author: dpapad <dpapad@chromium.org> Date: Wed Aug 01 01:45:40 2018 WebUI: Make WebUIPolymer2 flag work for optimize_webui=true, part 3. In this CL updating: - chrome://history - chrome://print - chrome://settings This adds some additional size to the binary, since both Polymer 1 and 2 HTML bundles are included. This is temporary and the Polymer 1 version will be removed once the migration is completed Bug: 862472 Change-Id: Ia77a01b730630ab04a34483c7f0a53358501ceed Reviewed-on: https://chromium-review.googlesource.com/1155834 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579663} [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/browser_resources.grd [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/resources/md_history/BUILD.gn [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/resources/print_preview/BUILD.gn [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/resources/print_preview/print_preview_resources_vulcanized.grd [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/resources/settings/BUILD.gn [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/resources/settings/settings_resources_vulcanized.grd [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/ui/webui/print_preview/print_preview_ui.cc [modify] https://crrev.com/27176197c23ea72e3f1ebfeb1d928f961da399e2/chrome/browser/ui/webui/settings/md_settings_ui.cc
,
Aug 1
Next step is to run all WebUI tests (some or browser_tests some are interactive_ui_tests) with the flag enabled (in addition to the default tests that have the flag disabled). CL in progress is at https://chromium-review.googlesource.com/c/chromium/src/+/1132320.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4c53a5c76413c7499ad89d621da4c23e5315428 commit b4c53a5c76413c7499ad89d621da4c23e5315428 Author: dpapad <dpapad@chromium.org> Date: Thu Aug 02 01:47:49 2018 WebUI: Declare Polymer 2 HTML bundle as output in optimize_webui.gni. Test: - Build chrome once, with optimize_webui=true - rm out/<out_folder>/gen/chrome/browser/resources/settings/vulcanized.p2.html. - Build chrome again. There should be no errors. Before this CL an error is thrown, because the file is not re-generated and GRIT fails to find it. After this CL, the file is correctly re-generated. Bug: 862472 Change-Id: Idd3896a74b8791558719052f145bb3a500005daf Reviewed-on: https://chromium-review.googlesource.com/1159276 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580027} [modify] https://crrev.com/b4c53a5c76413c7499ad89d621da4c23e5315428/chrome/browser/resources/optimize_webui.gni
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/860b573e427a3065e8c590a43f1063e6e2436dea commit 860b573e427a3065e8c590a43f1063e6e2436dea Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Thu Aug 02 17:28:08 2018 Settings Polymer 2: Fix some CrOS errors that happen on page load. These errors are causing all of the Settings tests to fail on CrOS. Fixing those in preparation of adding webui_polymer2_browser_tests test suite. Bug: 862472 Change-Id: Ica46f1fbef0f119c554d9003734544606c095c3c Reviewed-on: https://chromium-review.googlesource.com/1160864 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580228} [modify] https://crrev.com/860b573e427a3065e8c590a43f1063e6e2436dea/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js [modify] https://crrev.com/860b573e427a3065e8c590a43f1063e6e2436dea/ui/webui/resources/cr_components/chromeos/network/network_config.js
,
Aug 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27f35c78407491bcd130083968f4430209db01a7 commit 27f35c78407491bcd130083968f4430209db01a7 Author: rbpotter <rbpotter@chromium.org> Date: Tue Aug 14 22:02:47 2018 WebUI Polymer 2: Run various tests with WebUIPolymer2 flag enabled. Specifically, adding new test suites webui_polymer2_browser_tests and webui_polymer2_interactive_ui_tests that run a given list of tests and explicitly excludes currently failing tests. This will allow gradually getting to a state where all tests are passing with the flag on. Bug: 862472 Change-Id: Ia19ae36a4b2b63499b970e14c742b7719e118f83 Reviewed-on: https://chromium-review.googlesource.com/1132320 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#583049} [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/chrome/test/BUILD.gn [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.clang.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.linux.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.mac.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.memory.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/chromium.win.json [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/filters/webui_polymer2_browser_tests.filter [add] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter [modify] https://crrev.com/27f35c78407491bcd130083968f4430209db01a7/testing/buildbot/test_suites.pyl
,
Aug 15
After the CL in c#26, we observed new test failures on the clang ToTWin bot: CrSettingsIncompatibleApplicationsPageTest.All CrSettingsChromeCleanupPageTest.All CrSettingsMetricsReportingTest.All https://ci.chromium.org/buildbot/chromium.clang/ToTWin/2019 Should I add them to the webui_polymer2_browser_tests.filter file?
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aecc07d84543e354b803824fd5ba8837852c6fab commit aecc07d84543e354b803824fd5ba8837852c6fab Author: rbpotter <rbpotter@chromium.org> Date: Wed Aug 15 23:19:02 2018 WebUI Polymer2: Exclude failing tests interactive_ui_tests: These tests are flaky on debug builds. browser_tests: These tests are failing on official builds. Bug: 862472 Change-Id: I4ec7ae2c6f42abd3ccaf023dc803d3317faa1434 Reviewed-on: https://chromium-review.googlesource.com/1176206 Reviewed-by: Reid Kleckner <rnk@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#583437} [modify] https://crrev.com/aecc07d84543e354b803824fd5ba8837852c6fab/testing/buildbot/filters/webui_polymer2_browser_tests.filter [modify] https://crrev.com/aecc07d84543e354b803824fd5ba8837852c6fab/testing/buildbot/filters/webui_polymer2_interactive_ui_tests.filter
,
Sep 5
Marking this as fixed. AFAIK, there are no pending tasks (the flag already exists and is being used by tests as well).
,
Sep 20
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Jul 11Cc: steve...@chromium.org