New issue
Advanced search Search tips

Issue 862462 link

Starred by 1 user
Status: Assigned
Owner:
ftirelo@chromium.org
Cc:
viswa.karala@chromium.org
tapted@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Change views::Separator to make it explicit orientation depends on context

Project Member Reported by ftirelo@chromium.org, Jul 11 
Chrome Version: M69
OS: all platforms

We have a few places in the code base (such as the Autofill dropdown) that would benefit from support to vertical separators from views::Separator (see discussion in crrev.com/c/1131680).

Comment 1 by ftirelo@chromium.org, Jul 12

Summary: Change views::Separator to make it explicit orientation depends on context (was: Change views::Separator to allow vertical separators)
Horizontal separators are already supported, and orientation is basically dependent on the parent view's layout. For example, in chrome/browser/ui/views/profiles/profile_chooser_view.cc, all separators are horizontal because they are added to an 1-column GridLayout; for chrome/browser/ui/views/find_bar_view.cc on the other hand, the separator is added to a horizontal BoxLayout, so the separator is vertical.

A few method/field names in views::Separator (e.g. SetPreferredHeight) may be misleading in that sense.

Comment 2 by viswa.karala@chromium.org, Nov 21

Cc: viswa.karala@chromium.org
Labels: Hotlist-DesktopUIValid
**UI mass Triage**

Updating label for expert review.

Thanks!
►

Sign in to add a comment