New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862460 link

Starred by 1 user
Status: Fixed
Owner:
█ mrunal.k...@intel.com
Last visit > 30 days ago
Closed: Dec 12
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 913149
Blocking:
issue 257511



Sign in to add a comment

wakelock-disabled-by-feature-policy.https.sub.html fails

Project Member Reported by mrunal.k...@intel.com, Jul 11 
third_party/WebKit/LayoutTests/external/wpt/wake-lock/wakelock-disabled-by-feature-policy.https.sub.html
fails as observed in, 
https://chromium-review.googlesource.com/c/chromium/src/+/918062

Expected:
This is a testharness.js-based test.
PASS Feature-Policy header {"wake-lock" : []} disallows the top-level document.
PASS Feature-Policy header {"wake-lock" : []} disallows same-origin iframes.
PASS Feature-Policy header {"wake-lock" : []} disallows cross-origin iframes.

Observed:
This is a testharness.js-based test.
FAIL Feature-Policy header {"wake-lock" : []} disallows the top-level document. assert_unreached: Should have rejected: undefined Reached unreachable code
FAIL Feature-Policy header {"wake-lock" : []} disallows same-origin iframes. assert_false: navigator.getWakeLock("screen") expected false got true
FAIL Feature-Policy header {"wake-lock" : []} disallows cross-origin iframes. assert_false: navigator.getWakeLock("screen") expected false got true
wakelock-disabled-by-feature-policy.https.sub.html
1.1 KB View Download

Comment 1 by reillyg@chromium.org, Jul 11

Labels: OS-Android
Status: Assigned (was: Untriaged)
Summary: wakelock-disabled-by-feature-policy.https.sub.html fails (was: Wake Lock Test fails when disabled by feature policy)

Comment 2 by mrunal.k...@intel.com, Dec 8

Blockedon: 913149
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e5e1813e67fc6e07f7984f612ba99bffb240fb9

commit 2e5e1813e67fc6e07f7984f612ba99bffb240fb9
Author: Mrunal Kapade <mrunal.kapade@intel.com>
Date: Wed Dec 12 19:03:31 2018

Wake Lock API: Add checks for feature policy.

Added checks for feature policy attribute. This fixes all feature policy
related tests.

BUG= 862460 ,257511

Change-Id: I6258c41dcca164f7c6584ba4a387860237ca3ba3
Reviewed-on: https://chromium-review.googlesource.com/c/1343193
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com>
Cr-Commit-Position: refs/heads/master@{#615985}
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/third_party/blink/common/feature_policy/feature_policy.cc
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/third_party/blink/public/mojom/feature_policy/feature_policy.mojom
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/third_party/blink/renderer/core/feature_policy/feature_policy.cc
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/third_party/blink/renderer/modules/wake_lock/navigator_wake_lock.cc
[delete] https://crrev.com/631de05f60396066a876145334427efd257188b2/third_party/blink/web_tests/external/wpt/wake-lock/wakelock-disabled-by-feature-policy.https.sub-expected.txt
[delete] https://crrev.com/631de05f60396066a876145334427efd257188b2/third_party/blink/web_tests/external/wpt/wake-lock/wakelock-enabled-by-feature-policy-attribute-redirect-on-load.https.sub-expected.txt
[delete] https://crrev.com/631de05f60396066a876145334427efd257188b2/third_party/blink/web_tests/external/wpt/wake-lock/wakelock-enabled-on-self-origin-by-feature-policy.https.sub-expected.txt
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/third_party/blink/web_tests/external/wpt/wake-lock/wakelock-enabled-on-self-origin-by-feature-policy.https.sub.html
[modify] https://crrev.com/2e5e1813e67fc6e07f7984f612ba99bffb240fb9/tools/metrics/histograms/enums.xml

Comment 4 by mrunal.k...@intel.com, Dec 12

Cc: -jochen@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment