New issue
Advanced search Search tips

Issue 862455 link

Starred by 2 users
Status: Started
Owner:
jsb...@chromium.org
Cc:
pwnall@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-11-15
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Web Locks API: remove RuntimeFlag

Project Member Reported by jsb...@chromium.org, Jul 11 
Per https://chromium-review.googlesource.com/c/chromium/src/+/1132384

We're shipping the feature so have flipped the entry in 
third_party/blink/renderer/platform/runtime_enabled_features.json5 to status: "stable"

After sufficient time (say, November) we can remove the flag from the config file and also the IDL files.

Comment 1 by jsb...@chromium.org, Jul 11

Components: Blink>Storage
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ca2d0776f9d68ed84a596fe525973a31ff6040

commit 37ca2d0776f9d68ed84a596fe525973a31ff6040
Author: Joshua Bell <jsbell@chromium.org>
Date: Wed Jul 11 15:35:58 2018

Web Locks API: Enable in stable

Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/e2fg_-Ha-AE/discussion

Chrome Status Entry: https://www.chromestatus.com/feature/5712361335816192

Bug:  161072 ,862455
Change-Id: Ibdab33ae6dabe97b9f1fffeed413c09690e56bea
Reviewed-on: https://chromium-review.googlesource.com/1132384
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574173}
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/blink/renderer/modules/locks/lock.idl
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/blink/renderer/modules/locks/lock_manager.idl
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/blink/renderer/modules/locks/navigator_locks.idl
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
[modify] https://crrev.com/37ca2d0776f9d68ed84a596fe525973a31ff6040/third_party/blink/renderer/platform/runtime_enabled_features.json5

Comment 3 by monor...@bugs.chromium.org, Nov 15 

The NextAction date has arrived: 2018-11-15

Comment 4 by jsb...@chromium.org, Nov 27

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4dcf611460930a663a7b8725ae62c23932cef4f4

commit 4dcf611460930a663a7b8725ae62c23932cef4f4
Author: Joshua Bell <jsbell@chromium.org>
Date: Wed Nov 28 02:52:10 2018

Retire WebLocksAPI runtime enabled flag.

Feature shipped in M69

Bug: 862455
Change-Id: Ie729a201fe30449123dcc22147301b152a5ff327
Reviewed-on: https://chromium-review.googlesource.com/c/1338721
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611535}
[modify] https://crrev.com/4dcf611460930a663a7b8725ae62c23932cef4f4/third_party/blink/renderer/modules/locks/lock.idl
[modify] https://crrev.com/4dcf611460930a663a7b8725ae62c23932cef4f4/third_party/blink/renderer/modules/locks/lock_manager.idl
[modify] https://crrev.com/4dcf611460930a663a7b8725ae62c23932cef4f4/third_party/blink/renderer/modules/locks/navigator_locks.idl
[modify] https://crrev.com/4dcf611460930a663a7b8725ae62c23932cef4f4/third_party/blink/renderer/modules/locks/worker_navigator_locks.idl
[modify] https://crrev.com/4dcf611460930a663a7b8725ae62c23932cef4f4/third_party/blink/renderer/platform/runtime_enabled_features.json5
[delete] https://crrev.com/604a85fca8bc1c210b76182d2551291a5eed9ca2/third_party/blink/web_tests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-serviceworker-disabled.js
[delete] https://crrev.com/604a85fca8bc1c210b76182d2551291a5eed9ca2/third_party/blink/web_tests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-serviceworker-enabled.php
[delete] https://crrev.com/604a85fca8bc1c210b76182d2551291a5eed9ca2/third_party/blink/web_tests/http/tests/origin_trials/webexposed/resources/weblocksapi-origin-trial-interfaces-worker.js
[delete] https://crrev.com/604a85fca8bc1c210b76182d2551291a5eed9ca2/third_party/blink/web_tests/http/tests/origin_trials/webexposed/weblocksapi-origin-trial-interfaces.html
►

Sign in to add a comment