New issue
Advanced search Search tips

Issue 862446 link

Starred by 1 user
Status: Fixed
Owner:
mea...@chromium.org
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a presubmit check for ssl_error_assistant.asciipb

Project Member Reported by mea...@chromium.org, Jul 10 
The version_id field of this proto needs to be updated after every change. Add a presubmit to check that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8aa18c8522f5077d1f27ff125e2eb52b8a6fe1

commit fb8aa18c8522f5077d1f27ff125e2eb52b8a6fe1
Author: Mustafa Emre Acer <meacer@chromium.org>
Date: Wed Jul 11 17:30:03 2018

Add presubmit for ssl_cert_analysis.asciipb

Bug:  862446 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iac6b72b49795f49d966476f09c97d0275283b223
Reviewed-on: https://chromium-review.googlesource.com/1132549
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574217}
[add] https://crrev.com/fb8aa18c8522f5077d1f27ff125e2eb52b8a6fe1/chrome/browser/resources/ssl/ssl_error_assistant/PRESUBMIT.py

Comment 2 by mea...@chromium.org, Jul 11

Status: Fixed (was: Assigned)
►

Sign in to add a comment