Show network selection screen in a demo setup flow. Add additional custom element 'Offline demo mode' to the network lists. Selection of this element will initiate offline demo mode setup. Mock: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZeqwFvuvKaZQ/files/MCHKwkUMyliQOTwv4a7LVhDewMSJbxAVNpw
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e commit 6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e Author: Aga Wronska <agawronska@chromium.org> Date: Fri Jul 13 17:49:43 2018 Extract network selection dialog from OOBE welcome element. This allows for easier customization and showing of network dialog from different parts of OOBE flow. The corresponding OOBE screen will be added in a following change. Bug: 862445 Test: manually Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibdf039d1b0b43bb704b3f4daf3f8cb2d0b0eff40 Reviewed-on: https://chromium-review.googlesource.com/1132552 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#574968} [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/custom_elements_oobe.html [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/custom_elements_oobe.js [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/network_select_login.js [add] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_network_dialog.css [add] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_network_dialog.html [add] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_network_dialog.js [add] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_network_dialog_icons.html [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_welcome.css [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_welcome.html [modify] https://crrev.com/6aeff6f80108d0ab4f68b08c95b45d9d5db7ca9e/chrome/browser/resources/chromeos/login/oobe_welcome.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1001fd375442428751b18f3fed991c77874b92eb commit 1001fd375442428751b18f3fed991c77874b92eb Author: Aga Wronska <agawronska@chromium.org> Date: Wed Jul 25 18:42:35 2018 Separate network screen from welcome screen. Bug: 862445 Test: Run NetworkScreenTest, NetworkScreenUnittest and wizard_controller_browsertests Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9e71b2b4d179127113b11c4aade14597519565fd Reviewed-on: https://chromium-review.googlesource.com/1139586 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#577991} [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/oobe_screen.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/oobe_screen.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/base_screen.h [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/mock_network_screen.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/mock_network_screen.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/mock_welcome_screen.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/mock_welcome_screen.h [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/network_screen.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/network_screen.h [rename] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/network_screen_unittest.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/network_screen_view.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/screen_exit_code.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/screen_exit_code.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/welcome_screen.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/welcome_screen.h [delete] https://crrev.com/2ae556091aa79c9fef724bd55a93249f7a942e26/chrome/browser/chromeos/login/screens/welcome_screen_unittest.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/screens/welcome_view.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/custom_elements_oobe.html [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/custom_elements_oobe.js [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe.js [rename] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_network.css [rename] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_network.html [rename] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_network.js [rename] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_network_icons.html [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_screen_network.html [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_screen_network.js [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_screen_welcome.js [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_screens.html [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_welcome.html [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_welcome.js [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [add] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/welcome_screen_handler.cc [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/browser/ui/webui/chromeos/login/welcome_screen_handler.h [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/chrome/test/BUILD.gn [modify] https://crrev.com/1001fd375442428751b18f3fed991c77874b92eb/ui/login/display_manager.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2689d9febeebf37a2e102d4bfbf5ad48819a28 commit 8a2689d9febeebf37a2e102d4bfbf5ad48819a28 Author: Aga Wronska <agawronska@chromium.org> Date: Wed Jul 25 19:39:16 2018 Show network and update screens in demo mode setup flow. Bug: 857519 , 862445 Test: Run DemoSetupTest and wizard_controller_browsertests. Change-Id: I95a343ad740ac70a1c33db152a3fda1172d10912 Reviewed-on: https://chromium-review.googlesource.com/1141361 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#578019} [modify] https://crrev.com/8a2689d9febeebf37a2e102d4bfbf5ad48819a28/chrome/browser/chromeos/login/demo_setup_browsertest.cc [modify] https://crrev.com/8a2689d9febeebf37a2e102d4bfbf5ad48819a28/chrome/browser/chromeos/login/screens/network_screen.h [modify] https://crrev.com/8a2689d9febeebf37a2e102d4bfbf5ad48819a28/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/8a2689d9febeebf37a2e102d4bfbf5ad48819a28/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/8a2689d9febeebf37a2e102d4bfbf5ad48819a28/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7120df58421865865bca130be6655378d3c871b commit a7120df58421865865bca130be6655378d3c871b Author: Aga Wronska <agawronska@chromium.org> Date: Fri Jul 27 22:57:34 2018 Show offline demo mode option on network screen in demo mode setup flow. Real usage of the offline setup on network list will be implemented separately. Bug: 862445 Test: Run DemoSetupTest and wizard_controller_browsertests. Change-Id: I67c0ca2862ca30fe2a2c2115d413fe0f7dae0191 Reviewed-on: https://chromium-review.googlesource.com/1151951 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#578844} [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/demo_setup_browsertest.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/screens/network_screen.h [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/screens/screen_exit_code.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/screens/screen_exit_code.h [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/resources/chromeos/login/network_select_login.js [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/resources/chromeos/login/oobe_network.js [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/resources/chromeos/login/oobe_network_icons.html [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/resources/chromeos/login/oobe_screen_network.js [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/ui/webui/resources/cr_elements/chromeos/network/cr_network_list.js [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/ui/webui/resources/cr_elements/chromeos/network/cr_network_list_types.js [modify] https://crrev.com/a7120df58421865865bca130be6655378d3c871b/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2deb096016e07d61f3129df5f4ee2d0793ec40db commit 2deb096016e07d61f3129df5f4ee2d0793ec40db Author: Aga Wronska <agawronska@chromium.org> Date: Fri Aug 03 16:03:15 2018 Fix regression: clicking network on the network screen does not continue to the next screen. Regression was introduced by network screen refacoring at: https://chromium.googlesource.com/chromium/src/+/1001fd375442428751b18f3fed991c77874b92eb Bug: 862445 , 870227 Test: DemoSetupTest Change-Id: I993734fe3d62bd6903454208563e60cff1ba702e Reviewed-on: https://chromium-review.googlesource.com/1157701 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#580563} [modify] https://crrev.com/2deb096016e07d61f3129df5f4ee2d0793ec40db/chrome/browser/chromeos/login/demo_setup_browsertest.cc [modify] https://crrev.com/2deb096016e07d61f3129df5f4ee2d0793ec40db/chrome/browser/resources/chromeos/login/network_select_login.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d commit 3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d Author: Aga Wronska <agawronska@chromium.org> Date: Mon Aug 06 18:53:39 2018 Remove dev screen for choosing online/offline setup and run final demo mode setup flow. * Change DemoSetupController delegate into callback passed to Enroll() * Pass info about enrollment type separately from Enroll() request * Store DemoSetupController instance in WizardController instead of DemoSetupScreen for easier storage and access to demo setup flow status Change-Id: I43f2f28dfc2daea519849d222ea5a73561522516 Bug: 862445 Test: Run DemoSetupTest, DemoSetupControllerTest and wizard_controller_browsertest. Reviewed-on: https://chromium-review.googlesource.com/1155152 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#580937} [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/arc/arc_util.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.h [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/demo_mode/demo_setup_controller_unittest.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/demo_setup_browsertest.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/screens/demo_setup_screen.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/screens/demo_setup_screen.h [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/screens/mock_demo_setup_screen.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/resources/chromeos/login/demo_setup.html [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/resources/chromeos/login/demo_setup.js [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/resources/chromeos/login/oobe_screen_demo_setup.js [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.cc [modify] https://crrev.com/3bcccb0add06dbd8b130bd0c55b5ab92e51dc56d/chrome/browser/ui/webui/chromeos/login/demo_setup_screen_handler.h
Comment 1 by bugdroid1@chromium.org
, Jul 13