New issue
Advanced search Search tips

Issue 862431 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----

Blocked on:
issue 862793



Sign in to add a comment

tko parser fail in skylab provision

Project Member Reported by xixuan@chromium.org, Jul 10

Issue description

https://chrome-swarming.appspot.com/task?id=3e9e357e56c41310&refresh=10

no error in status.log, but traceback shows tko errors:

Traceback (most recent call last):
  File "/usr/local/autotest/tko/parse", line 5, in <module>
    parse.main()
  File "/usr/local/autotest/tko/parse.py", line 703, in main
    assert os.path.exists(results_dir)
AssertionError


 
Owner: pprabhu@chromium.org
Status: Assigned (was: Untriaged)
Blockedon: 862793
The parse failure is correct. The test execution before the parse step failed, early enough that there was no results directory to parse.

The problem is that stderr from lucifer was lost in the test running step, so I don't know why the test itself failed.
(note that provision passed)
Owner: ayatane@chromium.org
The failure is probably in Lucifer's keyval code.  Due to the error priority, the earlier error gets overridden by the parse failure.

Related to  Issue 862793 
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/4a6cb8025ad8ea3bb6850e59ca7aee784644f60b

commit 4a6cb8025ad8ea3bb6850e59ca7aee784644f60b
Author: Allen Li <ayatane@google.com>
Date: Mon Jul 16 22:48:52 2018

lucifer: Make dir for keyvals

The directory the keyvals should be put in wasn't being created until running
autoserv (which happens after the keyvals are created).

BUG= chromium:862431 
TEST=None

Change-Id: I40b3a91aa348224f65e8726464187fb033bd6e2d
Reviewed-on: https://chromium-review.googlesource.com/1135709
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/4a6cb8025ad8ea3bb6850e59ca7aee784644f60b/src/lucifer/cmd/lucifer/internal/lucifer_run_job/main.go

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/7c166df3fab011955cc11dab6af16ff982c13985

commit 7c166df3fab011955cc11dab6af16ff982c13985
Author: Allen Li <ayatane@google.com>
Date: Tue Jul 17 01:46:46 2018

lucifer: Deduplicate shared code

This is refactoring preparation for debugging linked bug.

BUG= chromium:862431 
TEST=None

Change-Id: I7db41d8a408da858c4fc5683b005957cdddf25f7
Reviewed-on: https://chromium-review.googlesource.com/1134521
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/7c166df3fab011955cc11dab6af16ff982c13985/src/lucifer/cmd/lucifer/testcmd.go

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/lucifer/+/52dbee60ded402a993b2867eb3cd419331ba951c

commit 52dbee60ded402a993b2867eb3cd419331ba951c
Author: Allen Li <ayatane@google.com>
Date: Tue Jul 17 01:46:46 2018

lucifer: Return first infra error instead of last

This is probably hiding a bug (see bug).

BUG= chromium:862431 
TEST=None

Change-Id: Ia2081acf1242f16428efe116b20d93afd96d0af5
Reviewed-on: https://chromium-review.googlesource.com/1134522
Commit-Ready: Allen Li <ayatane@chromium.org>
Tested-by: Allen Li <ayatane@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/52dbee60ded402a993b2867eb3cd419331ba951c/src/lucifer/cmd/lucifer/testcmd.go

Status: Fixed (was: Started)

Sign in to add a comment