New issue
Advanced search Search tips

Issue 862420 link

Starred by 2 users
Status: Started
Owner:
steve...@chromium.org
Cc:
jamescook@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 863439
Blocking:
issue 644355



Sign in to add a comment

Introduce cros_network_config.mojom for use in Ash

Project Member Reported by steve...@chromium.org, Jul 10 
Currently Ash instantiates its own NetworkHandler class to communicate with Shill.

This has potential consistency issues and should be avoided.

This proposal would implement a networking config mojo service in src/chromeos/networking, hosted by the Chrome process (for the near/mid term), implemented using Chrome's NetworkHandler instance.

The implementation will be nearly identical to the networkingPrivate extension implementation. Eventually it should be possible to use the mojo interface directly in the Settings UI and deprecate the networkingPrivate extension API in favor of the mojo interface.

Comment 1 by steve...@chromium.org, Jul 13

Blockedon: 863439
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a

commit c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 10 18:29:47 2019

Extract chromeos/geolocation and chromeos/timezone

chromeos/timezone depends on chromeos/geolocation which depends on
chromeos/network.

In order to properly extract //chromeos/network from //chromeos,
these will need to to be made independent components.

This CL adds separate BUILD.gn files, DEPS, and export defines in
preparation for making these components (which will need to occur
at the same time as making //chromeos/network a component).

For explicit DEPS extraction:
TBR=sky@chromium.org

Bug: 862420
Change-Id: Ia2c168d54db918bb08b87228e74a1a21524e9563
Reviewed-on: https://chromium-review.googlesource.com/c/1403814
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621653}
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/BUILD.gn
[add] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/BUILD.gn
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/DEPS
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/geoposition.h
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/simple_geolocation_provider.h
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/simple_geolocation_request.h
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/geolocation/simple_geolocation_request_test_monitor.h
[add] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/timezone/BUILD.gn
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/timezone/DEPS
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/timezone/timezone_provider.h
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/timezone/timezone_request.h
[modify] https://crrev.com/c2da12dee4af009b814288ba0e7d8d6bd1eb0c5a/chromeos/timezone/timezone_resolver.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb

commit 8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 11 16:11:31 2019

Make //chromeos/network a component

This also requires making components of source sets that depend
on //chromeos/network:
* //chromeos/geolocation
* //chromeos/timezone

For trivial include file renames:
TBR=sky@chromium.org

Bug: 862420
Change-Id: I5ce6004f4c5f1605e7ee3b2f8418e6c14de085de
Reviewed-on: https://chromium-review.googlesource.com/c/1405872
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622019}
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/ash/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/certificate_manager_model.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/certificate_manager_model_unittest.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/active_directory_policy_manager.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/device_network_configuration_updater.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/network_configuration_updater.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/policy_cert_service.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/chromeos/policy/user_network_configuration_updater_factory_browsertest.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/geolocation/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/DEPS
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/auto_connect_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/certificate_helper.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/certificate_pattern.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/client_cert_resolver.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/client_cert_resolver.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/client_cert_util.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/device_state.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/dhcp_pac_file_fetcher_chromeos.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/dhcp_pac_file_fetcher_factory_chromeos.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/fake_network_device_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/fast_transition_observer.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/firewall_hole.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/geolocation_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/managed_network_configuration_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/managed_network_configuration_handler_impl.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/managed_state.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/mock_managed_network_configuration_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/mock_network_device_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/mock_network_state_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_activation_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_cert_loader.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_cert_migrator.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_certificate_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_configuration_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_connect.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_connection_observer.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_device_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_device_handler_impl.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_event_log.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_handler_callbacks.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_ip_config.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_profile.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_profile_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_sms_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_state.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_state_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_state_handler_observer.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_type_pattern.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_ui_data.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/network_util.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_certificate_importer.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_certificate_importer_impl.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_mapper.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_merger.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_normalizer.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_parsed_certificates.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_signature.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_translation_tables.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_translator.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_utils.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_utils_unittest.cc
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/onc_validator.h
[rename] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/variable_expander.cc
[rename] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/variable_expander.h
[rename] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/variable_expander_fuzzer.cc
[rename] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/onc/variable_expander_unittest.cc
[rename] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/policy_certificate_provider.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/portal_detector/network_portal_detector.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/portal_detector/network_portal_detector_strategy.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/portal_detector/network_portal_detector_stub.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/prohibited_technologies_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/proxy/proxy_config_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/proxy/proxy_config_service_impl.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/proxy/ui_proxy_config.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/proxy/ui_proxy_config_service.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/shill_property_handler.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/shill_property_util.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/network/tether_constants.h
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/chromeos/timezone/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/components/arc/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/components/metrics/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/content/browser/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/extensions/browser/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/extensions/shell/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/services/device/BUILD.gn
[modify] https://crrev.com/8e97939ffcfadd6bc0ec25603abf3eb6c43c74bb/services/device/geolocation/BUILD.gn

Comment 4 by steve...@chromium.org, Jan 18 (4 days ago)

Blockedon: 923433

Comment 5 by steve...@chromium.org, Jan 18 (4 days ago)

Blockedon: -923433

Comment 6 by steve...@chromium.org, Jan 18 (4 days ago)

Blocking: -651157 644355
►

Sign in to add a comment