New issue
Advanced search Search tips

Issue 862414 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

content_browsertests TracingControllerTests crashing flakily on asan

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 10

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dpranke@google.com

content_browsertests failing on chromium.memory/Mac ASan 64 Tests (1)

Builders failed on: 
- Mac ASan 64 Tests (1): 
  https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20%281%29


 
Cc: primiano@chromium.org oysteine@chromium.org
Components: Speed>Tracing Tests>Flaky
Labels: -Sheriff-Chromium
Summary: content_browsertests TracingControllerTests crashing flakily on chromium.memory/Mac ASan 64 Tests (1) (was: content_browsertests failing on chromium.memory/Mac ASan 64 Tests (1))
Specifically, see 

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&showAllRuns=true&builder=chromium.memory%3AMac%20ASan%2064%20Tests%20(1)

the TracingControllerTest tests appear to have started flakily crashing around build https://ci.chromium.org/buildbot/chromium.memory/Mac%20ASan%2064%20Tests%20(1)/42075 (r570901, on 6/27.

Disabling multiple tests in https://crrev.com/c/1132429
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea09fc081c204276a0bbe77ac6e6ece70f47690

commit 2ea09fc081c204276a0bbe77ac6e6ece70f47690
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Jul 10 23:27:18 2018

Disable flaky TracingController content browser tests on Mac ASan.

TBR: oysteine@chromium.org, primiano@chromium.org
Bug:  862414 
Change-Id: I931b169a0ee99acefb1ce666e8bb5457731b5555
Reviewed-on: https://chromium-review.googlesource.com/1132429
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573982}
[modify] https://crrev.com/2ea09fc081c204276a0bbe77ac6e6ece70f47690/content/browser/tracing/tracing_controller_browsertest.cc

 Issue 862449  has been merged into this issue.
 Issue 862448  has been merged into this issue.
 Issue 862454  has been merged into this issue.
Owner: dtapu...@chromium.org
See the above duplicate bugs for FindIt's analysis, which is pointing to r573789 as a culprit.
Status: Assigned (was: Available)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886a3c80fac9355557a45645129801210d88fcf7

commit 886a3c80fac9355557a45645129801210d88fcf7
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Jul 11 01:01:28 2018

Disable flaky TracingController tests on Linux Asan as well.

Following up on r573982, looks like these tests are flaky on Linux Asan
as well. According to FindIt, the flakes are likely caused by
https://crrev.com/c/1131219 (r573789), so we should be able to revert
that CL and then revert this and r573982.

TBR=dtapuska@chromium.org, oysteine@chromium.org
BUG= 862414 

Change-Id: I88791155467f7808ca608a585fa8268a9f1afee0
Reviewed-on: https://chromium-review.googlesource.com/1132562
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574015}
[modify] https://crrev.com/886a3c80fac9355557a45645129801210d88fcf7/content/browser/tracing/tracing_controller_browsertest.cc

 Issue 862464  has been merged into this issue.
Summary: content_browsertests TracingControllerTests crashing flakily on asan (was: content_browsertests TracingControllerTests crashing flakily on chromium.memory/Mac ASan 64 Tests (1))
 Issue 862626  has been merged into this issue.
Note that this actually caught an issue with some flawed code that has existed for a few months because my change caused a code path to be traversed that wasn't previously traversed.

Fix is up here: https://chromium-review.googlesource.com/c/chromium/src/+/1133126 then I'll work at relanding and reverting the disabling CL.
I was thinking I'd re-enable the tests now, since there's (presumably) no reason not to?
Yup that is fine. My fix is in the CQ as well. Once that lands then I'll just have to reland https://crrev.com/573789 
Cc: -dpranke@google.com dpranke@chromium.org
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c81c011e59e26fc69d8b1cab989194e292a83e4

commit 4c81c011e59e26fc69d8b1cab989194e292a83e4
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Wed Jul 11 17:31:05 2018

Fix ASAN failure with tracing and hit testing.

Appears TracingUmaTracker was passing in a std::string's c_str into
the tracing macros. The tracing macros require a string literal because
it stores the pointers for later consumption.

BUG= 862414 

Change-Id: Ia695bdfbd4bf7370db4306169cfa7397527cc08d
Reviewed-on: https://chromium-review.googlesource.com/1133126
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574218}
[modify] https://crrev.com/4c81c011e59e26fc69d8b1cab989194e292a83e4/content/browser/renderer_host/render_widget_targeter.cc

Project Member

Comment 18 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5b38808c4def92a821392b167d71c0474e3b0da

commit e5b38808c4def92a821392b167d71c0474e3b0da
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Jul 11 17:45:54 2018

Re-enable TracingController tests I disabled yesterday.

A CL landed that made some TracingController browser tests flaky
under Asan, so I landed two CLs to disable the tests; the CL
was reverted, so we can reenable the tests now.

This CL reverts 2ea09fc081c204276a0bbe77ac6e6ece70f47690 and
886a3c80fac9355557a45645129801210d88fcf7.

TBR=oysteine@chromium.org

Bug:  862414 
Change-Id: I7ee8181af857ee0dfde29cc103bf7fa8bd970fcb
Reviewed-on: https://chromium-review.googlesource.com/1133585
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574231}
[modify] https://crrev.com/e5b38808c4def92a821392b167d71c0474e3b0da/content/browser/tracing/tracing_controller_browsertest.cc

 Issue 862637  has been merged into this issue.
Status: Fixed (was: Assigned)

Sign in to add a comment