New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Share kSurviveNavigationSeconds with ManagePasswordsUIController

Project Member Reported by siyua@chromium.org, Jul 10

Issue description

Number of seconds the bubble and icon stay even if the user navigates. This makes sure the user can see the bubble.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a742e15951f4e95d609b6628fc486a88b4fe0df

commit 5a742e15951f4e95d609b6628fc486a88b4fe0df
Author: Daniel Bratell <bratell@opera.com>
Date: Thu Jul 12 16:01:51 2018

[jumbo] Deduplicate a time constant in autofill code

Two different bubbles needed the same time constant and when
they got copies of the constant that broke certain jumbo
builds. This merges the constants to a single constant.

It also changes type to base::TimeDelta which is the actual
type needed and since the addition of constexpr can be used
in global constants.

Bug: 852904,862397
Change-Id: I52a63d3301efb1c7aec55541c15427c5d96ba524
Reviewed-on: https://chromium-review.googlesource.com/1134998
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574578}
[modify] https://crrev.com/5a742e15951f4e95d609b6628fc486a88b4fe0df/chrome/browser/ui/autofill/local_card_migration_bubble_controller_impl.cc
[modify] https://crrev.com/5a742e15951f4e95d609b6628fc486a88b4fe0df/chrome/browser/ui/autofill/popup_constants.h
[modify] https://crrev.com/5a742e15951f4e95d609b6628fc486a88b4fe0df/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc
[modify] https://crrev.com/5a742e15951f4e95d609b6628fc486a88b4fe0df/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc

Sign in to add a comment