New issue
Advanced search Search tips

Issue 862384 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 912218



Sign in to add a comment

Make sure Ash has logic to reconnect to gpu when gpu dies

Project Member Reported by sky@chromium.org, Jul 10

Issue description

When Ash runs out of process Ash acts as the gpu host. Ash needs to have the logic to reconnect to the gpu when the gpu restarts. Sadrul says the right place for this is likely DefaultGpuHost (currently in services/ui/gpu_host/gpu_host.*).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a16f79aae286ece27095b9dcf415af17b18db8

commit 06a16f79aae286ece27095b9dcf415af17b18db8
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Thu Nov 29 02:29:22 2018

Clean up flag for out-of-process Viz in Mash

Multi-Process Mash by default runs Viz in Ash process. There is a
--enable-viz flag used to run it as a separate process. This CL changes
that flag to a feature named MashOopViz and adds it to chrome://flags
page. When Viz runs properly as a standalone process, we can get rid of
this flag and make it the default behavior for Mash. Then,
--in-process-gpu flag can be used to run Viz in Ash process.

BUG=862384

Change-Id: I3015a0936a7287e7a7106c86bbed55863eabdbbe
Reviewed-on: https://chromium-review.googlesource.com/c/1349478
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611985}
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/chrome/browser/about_flags.cc
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/chrome/browser/flag-metadata.json
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/services/ws/gpu_host/gpu_host.cc
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/ui/base/ui_base_features.cc
[modify] https://crrev.com/06a16f79aae286ece27095b9dcf415af17b18db8/ui/base/ui_base_features.h

Blockedon: 912218

Sign in to add a comment