New issue
Advanced search Search tips

Issue 862382 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Refactor DialRegistry to not be a leaky singleton

Project Member Reported by rmcelrath@chromium.org, Jul 10

Issue description

We need to migrate DialRegistry from NetworkChangeNotifier to NetworkConnectionTracker as part of the network service migration (see  https://crbug.com/859133 ). NetworkConnectionTracker currently asserts in its destructor that no observers are registered, which fails because DialRegistry is a leaky singleton so never unregisters itself with the NetworkConnectionTracker.

We can remove the assertion for now, but long term it would be nicer if DialRegistry cleaned up after itself.
 
DialRegistry is not profile owned so there's no logical cleanup point, unless you want to add a blocking task at shutdown.
Status: WontFix (was: Untriaged)

Sign in to add a comment