New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862358 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

22.6% regression in system_health.memory_mobile at 1530706816:1530718215

Project Member Reported by tdres...@chromium.org, Jul 10

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=862358

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0119fceb2e8faed86b299fd5d492a794f047d4cdd2c3d6e2c3ec665041bf1ae6


Bot(s) for this bug's original alert(s):

health-plan-clankium-phone
Cc: lethalantidote@chromium.org
Owner: lethalantidote@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author lethalantidote@chromium.org ===

Hi lethalantidote@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : CJ DiMeglio
  Commit : 96c18b698ee5f6bf462fbffdc684bba0bd70fcbe
  Date   : Wed Jul 04 03:39:06 2018
  Subject: Creates the SurfaceLayer early for Video.

Bisect Details
  Configuration: clankium-phone-perf-bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:cc:effective_size_avg/background_news/background_news_nytimes
  Change       : 22.58% | 8634368.0 -> 10584064.0

Revision                                       Result                   N
android-chrome@5b9a4f3ea1                      8634368 +- 0.0           6      good
android-chrome@5b9a4f3ea1,chromium@572461      8634368 +- 0.0           6      good
android-chrome@5b9a4f3ea1,chromium@572462      10584064 +- 0.0          6      bad       <--
android-chrome@5b9a4f3ea1,chromium@572463      11233963 +- 1591920      6      bad
android-chrome@5b9a4f3ea1,chromium@572466      10584064 +- 0.0          6      bad
android-chrome@5b9a4f3ea1,chromium@572472      11233963 +- 1591920      6      bad
android-chrome@4ccead7f53                      10584064 +- 0.0          6      bad
android-chrome@21d8f31364                      10584064 +- 0.0          6      bad
android-chrome@90fbba92e7                      10584064 +- 0.0          6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=background.news.nytimes system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8941357723795333520


For feedback, file a bug with component Speed>Bisection
Cc: fsam...@chromium.org liber...@chromium.org
Owner: mlamouri@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1146905 should fix this according to my local tests. +fsamuel@  +liberato@ FYI
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd25332f520587bc0ef36bae838fb86b79b346dc

commit dd25332f520587bc0ef36bae838fb86b79b346dc
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jul 23 22:09:11 2018

VideoSurfaceLayer: set deadline to 0 for surface while not showing  something.

Bug: 862358
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I69053e71606a26a0ee7b517768456edbb75120a0
Reviewed-on: https://chromium-review.googlesource.com/1146905
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577276}
[modify] https://crrev.com/dd25332f520587bc0ef36bae838fb86b79b346dc/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc

Components: Speed>Metrics>SystemHealthRegressions
Components: -Speed>Metrics>SystemHealthRegressions

Sign in to add a comment