Little Close tab icon (x) overlaps with 3 dots and/or URL on tab switcher |
||||||
Issue descriptionVersion: Chrome Canary 69.0.3487.0 Device: iPhone 8 iOS: 11.4 Steps to reproduce: 1. Open several NTP with content (articles/pages) 2. Enter tab switcher mode 3. Observe little Close tab icons (x) overlapping with 3 dots and/or URL Observed results: Observe little Close tab icons (x) overlapping with 3 dots and/or URL Expected results: No overlapping should be seen Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Safari/Firefox: Firefox: No, Safari: No Bug reproducible on current stable build (App Version, iOS Version): No M67 Bug reproducible on the current beta channel build (App Version, iOS Version): No M68 Link to video/image: https://drive.google.com/open?id=1MaEGfCSBc1RhCb49SANnR2oAdSyJ8KL9
,
Jul 17
Issue 864512 has been merged into this issue.
,
Jul 17
From the duplicated bug: "We would like to add 4pt of spacing here".
,
Jul 17
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b531bc1adfc16456c3cff358f9239b418e456ae6 commit b531bc1adfc16456c3cff358f9239b418e456ae6 Author: Mark Cogan <marq@google.com> Date: Wed Jul 18 18:32:42 2018 [iOS] Fix spacing between grid cell title and close button. This Cl fixes the spacing between the grid cell title and the close button. When setting a constant offset for a trailing anchor, a positive constant results in the trailing anchor being further in the trailing direction, so a negative constant is needed to ensure the trailing anchor is on the leading side of the anchor it is constrained to. Per UX, the offset between the label and the button is set to 4 points. Bug: 862343 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I01fc0e927c281ea5b174af4126c7e44fd3fc4f7f Reviewed-on: https://chromium-review.googlesource.com/1140316 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576145} [modify] https://crrev.com/b531bc1adfc16456c3cff358f9239b418e456ae6/ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm [modify] https://crrev.com/b531bc1adfc16456c3cff358f9239b418e456ae6/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h [modify] https://crrev.com/b531bc1adfc16456c3cff358f9239b418e456ae6/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm
,
Jul 19
,
Jul 24
Verified in 70.0.3500.0 Canary, iPhone X iOS 11.4.1 https://drive.google.com/file/d/1hTT3e6OfvjRXkG3jA1HniZO5oq29wxxN/view?usp=sharing
,
Jul 24
No more overlap see. Verified on iPhone X iOS 11.4,iPhone 6 iOS 12 on build 70.0.3501.0 Canary
,
Jul 25
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by marq@chromium.org
, Jul 13Labels: -Restrict-View-Google -Pri-3 M-69 Q2 Pri-1
Owner: marq@chromium.org
Status: Assigned (was: Untriaged)