Increase spacing between alert indicators and x button |
|||||
Issue descriptionWhat is the expected result? 8dp between outbounds of alert indicator and outbounds of the x button What happens instead? 2dp
,
Jul 12
,
Jul 12
bsep: Sending to you since you're working in this area.
,
Jul 12
,
Jul 19
How's this going for branch?
,
Jul 19
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7db537ee5e8a1a61342e333194c574ce834aac51 commit 7db537ee5e8a1a61342e333194c574ce834aac51 Author: Bret Sepulveda <bsep@chromium.org> Date: Thu Jul 19 22:17:47 2018 Add padding between the alert indicator and close button on tabs. The new padding is per the spec. The padding disappears any time the close button does. The padding is increased in touch-optimized mode. There should be no change to pre-Refresh behavior. This patch also increases the width at which close buttons disappear in touchable mode, to account for the increased size of all elements. Bug: 862320 Change-Id: I75b607d80f0325b8d329213848a11540fdf845b5 Reviewed-on: https://chromium-review.googlesource.com/1142614 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#576660} [modify] https://crrev.com/7db537ee5e8a1a61342e333194c574ce834aac51/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/7db537ee5e8a1a61342e333194c574ce834aac51/chrome/browser/ui/views/tabs/tab.h [modify] https://crrev.com/7db537ee5e8a1a61342e333194c574ce834aac51/chrome/browser/ui/views/tabs/tab_unittest.cc
,
Jul 20
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bettes@chromium.org
, Jul 10