New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862319 link

Starred by 1 user
Status: Fixed
Owner:
█ eakuefner@chromium.org
Last visit > 30 days ago
Closed: Jul 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Implement POINT_ID diagnostic

Project Member Reported by eakuefner@chromium.org, Jul 10 
As discovered in https://chromium-review.googlesource.com/c/catapult/+/1093380 which implements revision timestamps (currently tracked by https://github.com/catapult-project/catapult/issues/4218), we can't simply use Chromium commit positions as an absolute fallback because of users like Chrome OS that specify CHROMIUM_COMMIT_POSITIONS but would rather use a custom point ID.

To rectify this, we need a POINT_ID diagnostic such that the fallback logic becomes:

* If POINT_ID is present, then use that.
* If CHROMIUM_COMMIT_POSITIONS is present, then use that.
* Otherwise, use REVISION_TIMESTAMPS.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/0ddcb32d165effb5e0663289aa32c5a35974a7ef

commit 0ddcb32d165effb5e0663289aa32c5a35974a7ef
Author: Ethan Kuefner <eakuefner@chromium.org>
Date: Thu Jul 19 19:10:34 2018

[TBMv2] Add POINT_ID reserved diagnostic

This CL adds a diagnostic POINT_ID to be used by Dashboard uploaders who are
not using CHROMIUM_COMMIT_POSITIONS.

A followup CL will add REVISION_TIMESTAMPS support, but this unblocks POINT_ID
to be used by Chrome OS (and possibly Fuchsia).

Bug:  chromium:862319 
Change-Id: I7384347fbd1f7785cb867b7ab8de5b85428974bb
Reviewed-on: https://chromium-review.googlesource.com/1142610
Commit-Queue: Ethan Kuefner <eakuefner@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/0ddcb32d165effb5e0663289aa32c5a35974a7ef/tracing/tracing/value/diagnostics/reserved_names.html
[modify] https://crrev.com/0ddcb32d165effb5e0663289aa32c5a35974a7ef/dashboard/dashboard/add_histograms_test.py
[modify] https://crrev.com/0ddcb32d165effb5e0663289aa32c5a35974a7ef/dashboard/dashboard/add_histograms.py
[modify] https://crrev.com/0ddcb32d165effb5e0663289aa32c5a35974a7ef/tracing/tracing/value/diagnostics/reserved_infos.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a8f2c3adea9cd2e8e1e9e2c3671d13888045fe

commit 39a8f2c3adea9cd2e8e1e9e2c3671d13888045fe
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 00:28:47 2018

Roll src/third_party/catapult 26a1ccee228a..0ddcb32d165e (1 commits)

https://chromium.googlesource.com/catapult.git/+log/26a1ccee228a..0ddcb32d165e


git log 26a1ccee228a..0ddcb32d165e --date=short --no-merges --format='%ad %ae %s'
2018-07-19 eakuefner@chromium.org [TBMv2] Add POINT_ID reserved diagnostic


Created with:
  gclient setdep -r src/third_party/catapult@0ddcb32d165e

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:862319 
TBR=sullivan@chromium.org

Change-Id: I2b42c1c30c398d3423f932b5dfbd8b5dc2483aa9
Reviewed-on: https://chromium-review.googlesource.com/1144280
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576716}
[modify] https://crrev.com/39a8f2c3adea9cd2e8e1e9e2c3671d13888045fe/DEPS

Comment 3 by eakuefner@chromium.org, Jul 24

Status: Fixed (was: Assigned)
This is done.
►

Sign in to add a comment