[iOS] Reading List Bug: Reading list screen has line separators throughout the screen |
||||||
Issue descriptionApp Version: 69.0.3486.0 canary iOS Version: 10.3.3 Only Device: iPhone 6 URL: Precondition: Have 2 Unread articles saved in Reading list Steps to reproduce: 1. Launch Chrome app 2. Tap on Reading List icon in NTP Observed results: Reading list screen has line separators throughout the screen Expected results: Reading list screen has line separators throughout the screen only between items Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/1KjRpRCkosJIh7c6mng8iKnBPrbg_zwmI/view
,
Jul 11
sczs, gambard, rohitrao: Is this an issue we've seen before in table views that display TableViewURLCells? I don't think I'm doing anything different here that would make this repro for reading list and not other use cases. Are any of you aware of a fix before I start investigating?
,
Jul 11
I don't think I have seen this before, but I am using the table views for the popup menu which don't have empty space at the bottom.
,
Jul 11
,
Jul 13
,
Jul 13
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6abe6670cac8df2fdfb6a7f01114858c06c23cb5 commit 6abe6670cac8df2fdfb6a7f01114858c06c23cb5 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Mon Jul 16 20:32:56 2018 [iOS] Remove cell separators from empty portion of reading list table. Bug: 862307 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I19f4051c152b0933d3142f734e9a253bea2b577d Reviewed-on: https://chromium-review.googlesource.com/1137257 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#575407} [modify] https://crrev.com/6abe6670cac8df2fdfb6a7f01114858c06c23cb5/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Jul 16
,
Jul 24
Verified in 70.0.3500.0 Canary, iPhone 6 iOS 10.3.3 Looks good. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kkhorimoto@chromium.org
, Jul 10