New issue
Advanced search Search tips

Issue 862306 link

Starred by 2 users
Status: Verified
Owner:
kkhorimoto@chromium.org
Closed: Jul 18
Cc:
sczs@chromium.org
gambard@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2
Team-Accessibility



Sign in to add a comment

[iOS] Reading List Bug: Reading List Offline indication green check is not read when in voiceover

Project Member Reported by shbarezer@chromium.org, Jul 10 
App Version: 69.0.3486.0 canary
iOS Version: 11.4.1, 12
Device: iPhone x, iPhone 7, iPad Pro
URL: 

Precondition:
Have 2 Unread articles saved in Reading list
Settings -> General -> Accessibility -> VoiceOver -> On

Steps to reproduce:
  1. Launch Chrome app
  2. Tap on Reading List  icon in NTP
  3. Focus on any of the Unread/Read articles

Observed results: Reading List Offline indication green check is not read when in voiceover  

Expected results:  Reading List Offline indication green check should be read when in voiceover , should read “Offline available”


Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA

Comment 1 by kkhorimoto@chromium.org, Jul 10

Labels: M-69

Comment 2 by gambard@chromium.org, Jul 11

Labels: Q2

Comment 3 by kkhorimoto@chromium.org, Jul 13

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a3cceb326c1bf52a126ae393a889ac3dfb8fbcc

commit 1a3cceb326c1bf52a126ae393a889ac3dfb8fbcc
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jul 18 01:21:44 2018

[iOS] Don't generate TableViewURLCell's a11y label if one is provided.

Previously, TableViewURLCell always returned a lazily created a11y
label created using the values of the UILabel subviews, which was
squashing the custom a11y label provided by TableViewItems.

Bug:  862306 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7210e683f4dfdcdbf0f2c60ecec3eb2a0683eeec
Reviewed-on: https://chromium-review.googlesource.com/1136902
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575890}
[modify] https://crrev.com/1a3cceb326c1bf52a126ae393a889ac3dfb8fbcc/ios/chrome/browser/ui/table_view/cells/table_view_url_item.mm

Comment 6 by kkhorimoto@chromium.org, Jul 18

Status: Fixed (was: Started)

Comment 7 by subhashi...@chromium.org, Jul 31

Status: Verified (was: Fixed)
Verified in:

App Version: 70.0.3508.0 canary
Devices: iPhone 7 Plus, iPhone 6 Plus, iPhone 8 Plus, iPad Air
iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5

Reading List Offline indication green check is read correctly when voiceover is ON.

Video:
https://drive.google.com/open?id=1qdgq4wvrs7OPMw7NnZ67a8GuxUXYRA4w
►

Sign in to add a comment