New issue
Advanced search Search tips

Issue 862299 link

Starred by 2 users
Status: Verified
Owner:
kkhorimoto@chromium.org
Closed: Jul 18
Cc:
sczs@chromium.org
gambard@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2
Team-Accessibility



Sign in to add a comment

[iOS] Reading List Bug: Reading List Unread articles item number is not read when in voiceover

Project Member Reported by shbarezer@chromium.org, Jul 10 
App Version: 69.0.3486.0 canary
iOS Version: 11.4.1, 12
Device: iPhone x, iPhone 7, iPad Pro
URL: 

Precondition:
Have 2 Unread articles saved in Reading list
Settings -> General -> Accessibility -> VoiceOver -> On

Steps to reproduce:
  1. Launch Chrome app
  2. Focus Reading List  icon in NTP

Observed results: Reading List Unread articles item number is not read when in voiceover  

Expected results:  Reading List Unread articles item number should be read when in voiceover

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA

Comment 1 by kkhorimoto@chromium.org, Jul 10

Labels: M-69

Comment 2 by gambard@chromium.org, Jul 11

Labels: Q2

Comment 3 by kkhorimoto@chromium.org, Jul 13

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee1229d3efe8303829fb4dd046634e7b9b8569a3

commit ee1229d3efe8303829fb4dd046634e7b9b8569a3
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Tue Jul 17 23:58:08 2018

[iOS] Update NTP Reading List a11y label to include unread article count

This CL updates ContentSuggestionsMostVisitedActionItem to support
custom a11y labels that differ from their titles, and adds a custom
label for the Reading List cell that states the number of unread
articles.

Bug:  862299 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I972b5996fb3398154f656b8ea056b9028d468af0
Reviewed-on: https://chromium-review.googlesource.com/1137027
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575860}
[modify] https://crrev.com/ee1229d3efe8303829fb4dd046634e7b9b8569a3/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/ee1229d3efe8303829fb4dd046634e7b9b8569a3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.h
[modify] https://crrev.com/ee1229d3efe8303829fb4dd046634e7b9b8569a3/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited_action_item.mm

Comment 6 by kkhorimoto@chromium.org, Jul 18

Status: Fixed (was: Started)

Comment 7 by subhashi...@chromium.org, Jul 31

Status: Verified (was: Fixed)
Verified in:

App Version: 70.0.3508.0 canary
Devices: iPhone 7 Plus, iPhone 6 Plus, iPhone 8 Plus, iPad Air
iOS Versions: 10.3.3, 11.4.1, 12.0 beta 5

Reading List Unread articles item number is read correctly when voiceover is ON
►

Sign in to add a comment