New issue
Advanced search Search tips

Issue 862276 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-08-21
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 871619



Sign in to add a comment

Adjust window drag handle/frame height correctly for various cases

Project Member Reported by kylixrd@chromium.org, Jul 10

Issue description

Chrome Version: 69.0.3487.1
OS: Windows

What steps will reproduce the problem?
(1) Open chrome://flags and disable Custom-drawn Windows 10 Titlebar
(2) Restart.
(3) Open several inactive tabs.
(4) Hover mouse over top 7-dips of inactive tab

What is the expected result?

No hover highlight should be seen and clicking this area should drag Chrome window.

What happens instead?

Hover highlight is shown and clicking this area selects the tab.


 
Labels: Group-Window_Frame
Blargh.  This affects win 7, but we _want_ it to affect win 7, because you can see the tab shapes there.  Which means I need to worry about the reverse case: probably with themes today we extend the drag handle down into the tab, and we shouldn't.  But if we don't extend the drag handle down, we should likely bump the top height up to compensate, either 6 DIP (which is what the extension into the inactive tabs is on current trunk) or at least 4 DIP (to give us an 8 DIP top drag handle).

Attached are shots of pre-refresh and the refresh +4 and +6 top handles on win 7.
pre_refresh.png
17.1 KB View Download
plus_4.png
18.6 KB View Download
plus_6.png
18.7 KB View Download
Cc: bettes@chromium.org
Labels: -Pri-3 Pri-1
bettes@ is pondering extending the frame when tabs are visible.  In the meantime, I at least need to fix "not extending on non-custom titlebar when it could" and "extending when tabs are visible".

The first of those is P3, the second is P2, deciding how to handle Win 7 glass is P1.
Labels: -Pri-1 Pri-2
Summary: Adjust window drag handle/frame height correctly for various cases (was: Drag handle doesn't extend into inactive tab when custom titlebar is disabled)
This now covers:

* Drag handle should extend into the tabs when custom titlebar is disabled but tab shapes are invisible
* Drag handle should not extend into the tabs when tab shapes are visible
* We should guarantee 8 DIP of drag handle above tabs when tab shapes are visible
Labels: M-69 Target-69
Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Blockedon: 871619
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28fc012f98300057aca454f4b02151051a10c79f

commit 28fc012f98300057aca454f4b02151051a10c79f
Author: Peter Kasting <pkasting@chromium.org>
Date: Thu Aug 09 02:00:04 2018

Disable window drag extension into tabs when background tabs are visible.

Bug:  862276 
Test: Install a theme with visible background tabs.  Hovering the top few px of the background tab and dragging should drag the tab, not the window.
Change-Id: Ic0fbea3bece38eb337d37b00efe9bbfa9b1564ae
Reviewed-on: https://chromium-review.googlesource.com/1166544
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581741}
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/ui/gfx/color_utils.cc
[modify] https://crrev.com/28fc012f98300057aca454f4b02151051a10c79f/ui/gfx/color_utils.h

How's this going these days?
The fix in comment 8 mostly addresses the second bullet in comment 4.  I have a CL that tries to address the third bullet, but in local testing I found a couple problems (one with its design and one with the heuristic in the comment 8 CL) so I'm fixing those; hopefully I'll have that up for re-review tonight, bsep will look overnight, and I'll land tomorrow.  Haven't yet looked at the first bullet of comment 4, which is the least critical of the three; that's on my plate after I land the above and a fix for  bug 862438 .
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/043dcce70d703128aa663bcda541c744ae970a6a

commit 043dcce70d703128aa663bcda541c744ae970a6a
Author: Peter Kasting <pkasting@chromium.org>
Date: Sat Aug 18 00:32:50 2018

Add extra frame height when background tabs are visible.

This ensures the user always has at least 8 DIP to drag with.

Bug:  862276 
Change-Id: I91592d9c29dbfad36f855249be467b98db0ede2d
Reviewed-on: https://chromium-review.googlesource.com/1173715
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584261}
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/043dcce70d703128aa663bcda541c744ae970a6a/chrome/browser/ui/views/tabs/tab_unittest.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Aug 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0532c4e2931053df5dad2cf2600a09af816854a6

commit 0532c4e2931053df5dad2cf2600a09af816854a6
Author: Peter Kasting <pkasting@chromium.org>
Date: Mon Aug 20 15:14:40 2018

Extend window drag handle into background tabs for non-custom frame.

This required:

* Deleting the old pre-custom-titlebar rect intersection code, which bypassed
  the drag extension code.  AFIACT this code had no advantages over the common
  code in BrowserNonClientFrameView.
* Fixing a color computation bug in GetTabBackgroundColor() that I introduced in
  https://chromium-review.googlesource.com/1173715 , where it ignored the
  requested active state of the frame.  This probably had other bad effects too.
* Fixing code in the tab strip that failed to mirror bounds correctly, so this
  would work in RTL.  Again, that probably resulted in other bugs too.

While testing that this worked right with the new tab button, I also fixed (via
simplification) an unrelated issue where the new tab button hit test region in
refresh was a rectangle instead of the correct path.

Bug:  862276 
Test: Run chrome on Windows 10 with --disable-features=Windows10CustomTitlebar, then hover the top couple pixels of a background tab in a restored window in the default theme.  The tab should not light up with a hover effect until you get 6 px or so down into the tab.
Change-Id: Iabc80cdde7f67251214c5308687105f13ea22f19
Reviewed-on: https://chromium-review.googlesource.com/1180594
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584447}
[modify] https://crrev.com/0532c4e2931053df5dad2cf2600a09af816854a6/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/0532c4e2931053df5dad2cf2600a09af816854a6/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/0532c4e2931053df5dad2cf2600a09af816854a6/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/0532c4e2931053df5dad2cf2600a09af816854a6/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/0532c4e2931053df5dad2cf2600a09af816854a6/chrome/browser/ui/views/tabs/tab_strip.cc

Labels: Merge-Request-69
Requesting merge for all three commits here (comment 8, comment 11, and comment 12).  Rationale is that this makes window drag handles behave in a way that's more consistent with their visible state, thus making it more possible to drag windows on Win 7, and less likely to confuse and frustrate users with custom themes.
Are all 3 changes looking good in canary and safe to merge?
Project Member

Comment 15 by sheriffbot@chromium.org, Aug 21

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
NextAction: 2018-08-21
Verified commits in comments 8 and 11 are working correctly in current Canary.  Comment 12 is not in today's Canary, will need to wait until tomorrow for that.
Sure, pls update bug with canary result tomorrow for Cl listed at #12. Thank you.
The NextAction date has arrived: 2018-08-21
Labels: Needs-Feedback
Tried checking the issue on reported chrome version 69.0.3487.1 and on the latest chrome version 70.0.3529.3 using Windows 7 with the below mentioned steps.
1. Launched chrome and navigated to chrome://flags
2. Disabled the flag Custom-drawn Windows 10 Titlebar
3. Relaunched chrome & opened multiple tabs
4. Hovered over the inactive tabs.

As per comment#0's expected and actual behaviour, still hover highlight is seen & clicking that area didn't drag any window on latest version. Similar behaviour is seen on reported version too. Attaching the screencast of the same for reference.
Note: Observed a change in the UI of the tabstrip.

As we couldn't confirm the fix as per comment#0, Could someone help us in verifying the fix and let us know if anything missed from our end.

Thanks!
862276.mp4
876 KB View Download
@17: Verified the commit in comment 12 on today's canary.

@19: It sounds like you're trying to verify the report in comment 0 (which is narrower than what this bug ultimately covers; that's basically the comment 12 commit).  If so, you need to be on Windows 10 (not 7), and you need to have top-chrome-md set to "Refresh".
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comments #13, #16 and #20. 
Project Member

Comment 22 by bugdroid1@chromium.org, Aug 21

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1

commit 1d7c0f76d5c4678a2d0f2b37001612c4acee34d1
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Aug 21 22:40:56 2018

Disable window drag extension into tabs when background tabs are visible.

Bug:  862276 
Test: Install a theme with visible background tabs.  Hovering the top few px of the background tab and dragging should drag the tab, not the window.
Change-Id: Ic0fbea3bece38eb337d37b00efe9bbfa9b1564ae
Reviewed-on: https://chromium-review.googlesource.com/1166544
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581741}(cherry picked from commit 28fc012f98300057aca454f4b02151051a10c79f)
Reviewed-on: https://chromium-review.googlesource.com/1184182
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#750}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/ui/gfx/color_utils.cc
[modify] https://crrev.com/1d7c0f76d5c4678a2d0f2b37001612c4acee34d1/ui/gfx/color_utils.h

Project Member

Comment 23 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a41850ac06cde994949556de762f030d40c6e21

commit 3a41850ac06cde994949556de762f030d40c6e21
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Aug 21 23:35:51 2018

Add extra frame height when background tabs are visible.

This ensures the user always has at least 8 DIP to drag with.

(cherry picked from commit 043dcce70d703128aa663bcda541c744ae970a6a)

Bug:  862276 
Change-Id: I91592d9c29dbfad36f855249be467b98db0ede2d
Reviewed-on: https://chromium-review.googlesource.com/1173715
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584261}
Reviewed-on: https://chromium-review.googlesource.com/1184263
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#754}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/desktop_linux_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_delegate.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout_unittest.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/3a41850ac06cde994949556de762f030d40c6e21/chrome/browser/ui/views/tabs/tab_unittest.cc

Status: Fixed (was: Started)
Fixed on trunk and M69.
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b24dbe4b3d265cc24c59b337a453e19a6e7088

commit 13b24dbe4b3d265cc24c59b337a453e19a6e7088
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Aug 21 23:36:39 2018

Extend window drag handle into background tabs for non-custom frame.

This required:

* Deleting the old pre-custom-titlebar rect intersection code, which bypassed
  the drag extension code.  AFIACT this code had no advantages over the common
  code in BrowserNonClientFrameView.
* Fixing a color computation bug in GetTabBackgroundColor() that I introduced in
  https://chromium-review.googlesource.com/1173715 , where it ignored the
  requested active state of the frame.  This probably had other bad effects too.
* Fixing code in the tab strip that failed to mirror bounds correctly, so this
  would work in RTL.  Again, that probably resulted in other bugs too.

While testing that this worked right with the new tab button, I also fixed (via
simplification) an unrelated issue where the new tab button hit test region in
refresh was a rectangle instead of the correct path.

Bug:  862276 
Test: Run chrome on Windows 10 with --disable-features=Windows10CustomTitlebar, then hover the top couple pixels of a background tab in a restored window in the default theme.  The tab should not light up with a hover effect until you get 6 px or so down into the tab.
Change-Id: Iabc80cdde7f67251214c5308687105f13ea22f19
Reviewed-on: https://chromium-review.googlesource.com/1180594
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#584447}(cherry picked from commit 0532c4e2931053df5dad2cf2600a09af816854a6)
Reviewed-on: https://chromium-review.googlesource.com/1184183
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#756}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/13b24dbe4b3d265cc24c59b337a453e19a6e7088/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/13b24dbe4b3d265cc24c59b337a453e19a6e7088/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/13b24dbe4b3d265cc24c59b337a453e19a6e7088/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/13b24dbe4b3d265cc24c59b337a453e19a6e7088/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/13b24dbe4b3d265cc24c59b337a453e19a6e7088/chrome/browser/ui/views/tabs/tab_strip.cc

Hey pkasting@: I noticed that your CL from C#23 also has an effect on Mac. The Tabstrip background increases by 1px (on my non-retina MacBook) when I install a Theme that uses Tab Shapes on background tabs. Since this issue was labeled as Windows-only, I am not sure if the effect was intended on other platforms too. Please ignore my comment, if it was intended or you can live with it. Thanks :)
Labels: OS-Chrome OS-Linux OS-Mac
Mac effect was intentional.
> Mac effect was intentional.

Okay, thanks.

Sign in to add a comment