New issue
Advanced search Search tips

Issue 862273 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[WebUI Refresh] Manage people background change

Project Member Reported by namratakannan@chromium.org, Jul 10

Issue description

Manage people dialog background color needs to be white.

Reason:
On windows, the difference in color between the title bar and bg color looks like a bug.
https://docs.google.com/presentation/d/1tlUSroWtG8HDXJPu_imQgr6wZmqr74BXe7RH7B81TaI/edit?ts=5b3fd8a4#slide=id.g3d448ede2c_0_110

Desired behavior:
https://screenshot.googleplex.com/kKwRQ8LPCLW

We had decided to make the bg color white for the buttons since the background color was gray, but since we are updating the bg color to white, the button color would stay white or transparent (similar to how they appear on dialogs)


 
Labels: OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)
Owner: aee@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be221fc5f10b2250a6bf6064cc51297b71f35656

commit be221fc5f10b2250a6bf6064cc51297b71f35656
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jul 11 20:41:19 2018

User Manager WebUI: update bg color

Bug:  862273 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3137dfd35e896196b2c6ee364cdbf4540823e9e6
Reviewed-on: https://chromium-review.googlesource.com/1132492
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574317}
[modify] https://crrev.com/be221fc5f10b2250a6bf6064cc51297b71f35656/chrome/browser/resources/md_user_manager/shared_styles.html
[modify] https://crrev.com/be221fc5f10b2250a6bf6064cc51297b71f35656/chrome/browser/resources/md_user_manager/user_manager.html

Status: Fixed (was: Started)
Cc: kkaluri@chromium.org
Labels: TE-Verified-69.0.3489.0 TE-Verified-M69
Verified this issue on Windows 10, Debian Rodete and Mac 10.13.4 with chrome #69.0.3489.0 and observed the add manager window buttons background color changed to White.

Hence adding TE-Verified labels.

Attaching the screenshot for reference.
862273-1.png
104 KB View Download

Sign in to add a comment