History landscape layout is overlap the notch |
|||||||
Issue descriptionApp Version: 69.0.3487.0 canary iOS Version: 11.4.1 Device: iPhone X Only URL: Steps to reproduce: 1. Launch Chrome app 2. Tap on History (Note: happens with Bookmarks, Recent Tabs etc.) 3. Change device to landscape mode Observed results: History landscape layout is overlap the notch Expected results: History landscape layout should not overlap the notch Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/12XNOk1uskQoIAt1OEYzfBO8hgq5Cuzbp/view
,
Jul 13
shbarezer@: can you clarify if this is only in an RTL language? Keeping at Pri-2 for now.
,
Jul 13
marq@ this is not just RTL, it happens also for EN when we turn the device to the other way (meaning: the notch is on the right) https://drive.google.com/file/d/1ZIOn3Op5PewIrpx39a2HPZLoLH2lPuqO/view
,
Jul 16
Since this is not only visible with RTL, bumping up to P1.
,
Jul 16
,
Jul 16
,
Jul 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44e3acd125853602fefa92ec01d9fb7394390d1a commit 44e3acd125853602fefa92ec01d9fb7394390d1a Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Jul 17 15:55:16 2018 [ios] Respect the safe area when presenting table view bubbles. BUG= 862255 TEST=On iPhoneX, rotate into landscape and open the Bookmarks. The bubble should not overlap with the notch, in both LTR and RTL languages. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I07c2215e7b3b6e01ee8e39cae6d03054199cb205 Reviewed-on: https://chromium-review.googlesource.com/1140195 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575656} [modify] https://crrev.com/44e3acd125853602fefa92ec01d9fb7394390d1a/ios/chrome/browser/ui/table_view/table_view_presentation_controller.mm
,
Jul 17
,
Jul 24
Verified on M70.0.3501.0 canary Device: iPhoneX, iOS: 12.0 beta#4 History and other similar dialogs are not overlapped on to the notch. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by subhashi...@chromium.org
, Jul 13