Issue metadata
Sign in to add a comment
|
2.6% regression in rasterize_time at 571139:571258 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 10
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/12881f92a40000
,
Jul 11
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/12881f92a40000 cut SkMaskBlurFilter code size by about half by mtklein@chromium.org https://skia.googlesource.com/skia/+/b06be0e8b909f7237dda6817bc6301826f7ede3f 68.43 → 70.15 (+1.722) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jul 11
This is the sort of speed/size tradeoff we'd expect from that change. Probably wouldn't want to land the CL the other way around (double code size for 3% speedup).
,
Jul 11
There was a time when we were collecting performance tradeoffs we're making. Are we still doing that?
,
Jul 11
I'm not familiar with that.
,
Jul 11
Sorry Mike, should have explictly mentioned +benhenry@, +ushesh@, to whom I intended to address that question.
,
Jul 11
It's been a while, but we have collected tradeoffs in the past. It might be good to do that again. go/chrome-speed-tradeoffs |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 10