Allow running WebRTC tryjobs on Chromium CLs |
||
Issue description
This can be used to see how a change in Chromium repo would affect WebRTC's build.
The difficulty is that WebRTC doees not directly depend on Chromium but rather on its subtree mirrors.
Currently all tryjobs fail with "Uncaught Exception: KeyError('root',)" in bot_update
https://ci.chromium.org/p/webrtc/builders/luci.webrtc.try/linux_compile_rel/61
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/ed89926f9a5baca36833854c239f9c4488dbdd45 commit ed89926f9a5baca36833854c239f9c4488dbdd45 Author: Oleh Prypin <oprypin@webrtc.org> Date: Wed Jul 11 06:46:54 2018 Implement WebRTC tryjobs on Chromium CLs WebRTC depends on Chromium through subtree mirrors like https://chromium.googlesource.com/chromium/src/build.git This works by forcing these to sync to HEAD and then applying the patch (obtained as a textual diff) from the Gerrit CL. The files will be in a dirty state but the next tryjob should reset all those changes. Dependent CLs are not supported. Changes to Chromium's DEPS file are not taken into account. Bug: chromium:862224 Change-Id: I85aed022a45a77aa5303c1cd0bedfaad29115285 Reviewed-on: https://chromium-review.googlesource.com/1131743 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> [add] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel_chromium.json [add] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_compile_rel_chromium_failing_patch.json [modify] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/README.recipes.md [modify] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipes/webrtc/standalone.py [modify] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipe_modules/webrtc/__init__.py [modify] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipe_modules/webrtc/test_api.py [modify] https://crrev.com/ed89926f9a5baca36833854c239f9c4488dbdd45/scripts/slave/recipe_modules/webrtc/api.py
,
Jul 11
Things to consider in the future: Somehow apply changes to Chromium's DEPS file. Chromium's support of WebRTC can be broken at HEAD and an innocent tryjob would fail. Maybe try to not sync to HEAD? But then there will be patch failures. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 10