New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862208 link

Starred by 2 users
Status: Verified
Owner:
justincohen@chromium.org
Closed: Jul 25
Cc:
gambard@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
q4



Sign in to add a comment

Fake omnibox width changes

Project Member Reported by shbarezer@chromium.org, Jul 10 
App Version: 69.0.3486.0 canary
iOS Version: 11.4.1, 12
Device: iPhone Only
URL: 

Proposed Priority: P2
Found-in Label [i.e found-in-m4x]: found-in-m69, found-in-canary,
Other applicable labels: Proj-UIRefresh, MS-New-Tab 

Steps to reproduce:
  1. Launch Chrome app
  2. Tap on History (Note: happens with Bookmarks, Recent Tabs etc.)
  3. Change device to landscape mode
  4. Back to Portrait mode
  5. Tap on Done

Observed results: Fake omnibox width changes

Expected results:  Fake omnibox width should be consistent

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: Not tested
Bug reproducible on Safari/Firefox: Firefox: , Safari: NA

Link to video/image:
https://drive.google.com/file/d/1_EB22tmOAZwq9Pa8MwxVKZe3aBoFa28u/view

Comment 1 by twelling...@chromium.org, Jul 10

Labels: zine-triaged

Comment 2 by marq@chromium.org, Jul 13

Cc: gambard@chromium.org
Labels: q4
Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)
Keeping P2 for now.

Comment 3 by justincohen@chromium.org, Jul 25

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfa5b989cbdee6924959baae352df25c7655eed1

commit bfa5b989cbdee6924959baae352df25c7655eed1
Author: Justin Cohen <justincohen@google.com>
Date: Wed Jul 25 09:26:33 2018

[ios] Correct content suggestions safe area on rotation.

Various safe area tweaks to correct the layout of fakebox on rotation
when presented under another view controller.

Bug:  866864 ,  862208 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8
Reviewed-on: https://chromium-review.googlesource.com/1149100
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577826}
[modify] https://crrev.com/bfa5b989cbdee6924959baae352df25c7655eed1/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/bfa5b989cbdee6924959baae352df25c7655eed1/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 5 by justincohen@chromium.org, Jul 25

Labels: Merge-Request-69
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 26

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c29f093ac39dae4b6c3df7f78f7313dc2c787781

commit c29f093ac39dae4b6c3df7f78f7313dc2c787781
Author: Justin Cohen <justincohen@google.com>
Date: Thu Jul 26 12:46:59 2018

[ios] Correct content suggestions safe area on rotation.

Various safe area tweaks to correct the layout of fakebox on rotation
when presented under another view controller.

Bug:  866864 ,  862208 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7fda5c1ae564825c203566add4c7e738bcb38eb8
Reviewed-on: https://chromium-review.googlesource.com/1149100
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577826}(cherry picked from commit bfa5b989cbdee6924959baae352df25c7655eed1)
Reviewed-on: https://chromium-review.googlesource.com/1150701
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#106}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/c29f093ac39dae4b6c3df7f78f7313dc2c787781/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_synchronizer.mm
[modify] https://crrev.com/c29f093ac39dae4b6c3df7f78f7313dc2c787781/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm

Comment 8 by rakurati@chromium.org, Aug 1

Status: Verified (was: Fixed)
Verified in 69.0.3497.22 beta, 70.0.3508.0 canary in iPhone 7plus(iOS 10.3.3), iPhone 8plus(iOS 12 beta 5) and iPhone7(iOS 11.4.1)

On following steps mentioned in comment #0, Fake omnibox width doesn't change.

link to video:
https://drive.google.com/file/d/11p8B6DCOMGNMD7YH5YQAYvfKBEjRNEWq/view?usp=sharing
►

Sign in to add a comment