power: need to identify model in power dashboard for unibuild devices. |
||
Issue descriptionCurrently power dashboard doesn't have way to differentiate between models of the same board using a unibuild image. Lets add that functionality.
,
Jul 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2017ffcef657c1fd8a50130befba3daba6d0653f commit 2017ffcef657c1fd8a50130befba3daba6d0653f Author: Todd Broch <tbroch@chromium.org> Date: Sun Jul 15 01:11:41 2018 power: Add platform name to power dashboard board if set. platform (AKA unibuild model) needed to distiguish data uploaded to dashboard so lets combine board + platform name strings where applicable. BUG= chromium:862195 TEST=run power_Display power_log.json is for eve, "board": "eve" for sona, "board": "nami_sona" Change-Id: I2f7d39e882db2d068a22b5e19d1e1b7da7d2fd40 Reviewed-on: https://chromium-review.googlesource.com/1131684 Commit-Ready: Todd Broch <tbroch@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org> [modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/client/bin/utils.py [modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/server/cros/power/power_dashboard.py [modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/client/cros/power/power_dashboard.py
,
Jul 16
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb commit f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb Author: Puthikorn Voravootivat <puthik@chromium.org> Date: Fri Jul 20 22:10:10 2018 power_dashboard: Don't add platform if it starts with board name We currently have kevin_kevin1 board in the dashboard because suprisingly kevin's platform is kevin1 not kevin. This CL is the workaround fix for that problem. BUG= chromium:862195 TEST=kevin on dashboard not keven_kevin1 Change-Id: Ic3d1fc2d626a60b89ee995782f5c49f19ce8bc28 Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1144626 Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb/server/cros/power/power_dashboard.py [modify] https://crrev.com/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb/client/cros/power/power_dashboard.py |
||
►
Sign in to add a comment |
||
Comment 1 by tbroch@chromium.org
, Jul 10Owner: tbroch@chromium.org
Status: Assigned (was: Untriaged)