New issue
Advanced search Search tips

Issue 862195 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

power: need to identify model in power dashboard for unibuild devices.

Project Member Reported by tbroch@chromium.org, Jul 10

Issue description

Currently power dashboard doesn't have way to differentiate between models of the same board using a unibuild image.  Lets add that functionality.


 
Cc: puthik@chromium.org
Owner: tbroch@chromium.org
Status: Assigned (was: Untriaged)
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1131684 for the model addition.


Need to chat w/ Opal about how we want to modify the dashboard to accomodate the field.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2017ffcef657c1fd8a50130befba3daba6d0653f

commit 2017ffcef657c1fd8a50130befba3daba6d0653f
Author: Todd Broch <tbroch@chromium.org>
Date: Sun Jul 15 01:11:41 2018

power: Add platform name to power dashboard board if set.

platform (AKA unibuild model) needed to distiguish data uploaded to
dashboard so lets combine board + platform name strings where
applicable.

BUG= chromium:862195 
TEST=run power_Display
  power_log.json is
    for eve,  "board": "eve"
    for sona, "board": "nami_sona"

Change-Id: I2f7d39e882db2d068a22b5e19d1e1b7da7d2fd40
Reviewed-on: https://chromium-review.googlesource.com/1131684
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>

[modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/client/bin/utils.py
[modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/server/cros/power/power_dashboard.py
[modify] https://crrev.com/2017ffcef657c1fd8a50130befba3daba6d0653f/client/cros/power/power_dashboard.py

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb

commit f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb
Author: Puthikorn Voravootivat <puthik@chromium.org>
Date: Fri Jul 20 22:10:10 2018

power_dashboard: Don't add platform if it starts with board name

We currently have kevin_kevin1 board in the dashboard because
suprisingly kevin's platform is kevin1 not kevin.

This CL is the workaround fix for that problem.

BUG= chromium:862195 
TEST=kevin on dashboard not keven_kevin1

Change-Id: Ic3d1fc2d626a60b89ee995782f5c49f19ce8bc28
Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1144626
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb/server/cros/power/power_dashboard.py
[modify] https://crrev.com/f4a3f5db6f4eaa8dcf9d8ffe7065d6501fe4ccbb/client/cros/power/power_dashboard.py

Sign in to add a comment