New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862192 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 862428



Sign in to add a comment

Show custom Chrome picture in toolbar

Project Member Reported by ew...@chromium.org, Jul 10

Issue description

Right now on Canary, if the user is not signed into the web content area, we always show the default "generic gray" person avatar in the toolbar: https://screenshot.googleplex.com/uFd8xqE0Hvb.png.

If the person is signed into the web content area and they have not changed their Chrome profile picture away from the default one, we show their GAIA photo: https://screenshot.googleplex.com/KhRRGtvyVZL.png.

If the person is signed into the web content area and they have changed their Chrome profile picture away from the default one, we show their Chrome profile picture: https://screenshot.googleplex.com/yCs9Rfiun4q.png.

We should change this logic so that we always show the Chrome profile picture if the user has set a custom one, regardless of whether the user has signed into the web. To be explicit, the behavior should be:
1. If the user has set a custom Chrome profile picture, always show that.
2. If the user has not set a custom Chrome profile picture, but they have signed in on the web, show their GAIA avatar.
3. If the user has neither set a custom Chrome profile picture nor signed in on the web, show the default "generic gray" avatar.

The only thing that needs to be updated is that we should show the Chrome profile picture if it's been changed from the default regardless of whether or not the user is signed in on the web.

Peter - does that make sense? Could you take a look at this?
 
Makes sense to me, sure can.

tangltom@ / msarda@: Can we detect "1. If the user has set a custom Chrome profile picture, always show that." or is setting no picture equivalent to setting the first default picture?
Blockedon: 862428
Labels: -Pri-2 -M-69 Pri-3
Lowering to P3 and removing the M-69 label because (a) we could solve this more holistically with Issue 862428 and (b) very few users have set a custom Chrome profile picture, so we don't necessary need to get this in for the 69 release.
Owner: ----
Status: Available (was: Assigned)
I'll unassign it then and mark it as available. FWIW I think the blocking issue should be fixed instead of this (so WontFixing or duping it would be fine too, whatever you prefer).
Status: WontFix (was: Available)
Agreed. Marking as WontFix

Sign in to add a comment