New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862186 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Task

Blocking:
issue 851433



Sign in to add a comment

Split ConsentAuditor interface from implementation.

Project Member Reported by vitaliii@chromium.org, Jul 10

Issue description

This is needed to unlink FakeConsentAuditor from the implementation, which blocks enabling separate consents datatype by default.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7782405912e05feca6e0cf3808ab8f3c8ff70f2f

commit 7782405912e05feca6e0cf3808ab8f3c8ff70f2f
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Jul 12 15:40:45 2018

[Sync::Consent] Split ConsentAuditor interface from implementation.

Also rewrite FakeConsentAuditor to implement the interface instead of
inheriting from the implementation. This unblocks enabling the separate
datatype feature by default.

Bug:  862186 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I474f74f12278221ef6278c120576f1ff1a224c4a
Reviewed-on: https://chromium-review.googlesource.com/1131508
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574569}
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/chrome/browser/consent_auditor/consent_auditor_test_utils.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/BUILD.gn
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/consent_auditor.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/consent_auditor.h
[add] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/consent_auditor_impl.cc
[add] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/consent_auditor_impl.h
[rename] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/consent_auditor_impl_unittest.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/fake_consent_auditor.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/components/consent_auditor/fake_consent_auditor.h
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/ios/chrome/browser/consent_auditor/consent_auditor_factory.cc
[modify] https://crrev.com/7782405912e05feca6e0cf3808ab8f3c8ff70f2f/ios/chrome/browser/ui/authentication/chrome_signin_view_controller_unittest.mm

Status: Fixed (was: Started)

Sign in to add a comment