[iOS] Reading List Bug: Mark Read/Mark Unread is not functional when selecting items from both categories. |
|||||
Issue descriptionApp Version: 69.0.3486.0 canary iOS Version: 11.4.1, 12 Device: iPhone Only URL: Precondition: Go to: chrome://flags -> Enable #collections-ui-reboot Have an Unread and Read articles saved in Reading list Steps to reproduce: 1. Launch Chrome app 2. Go to Reading List -> Edit 3. Select both Unread and Pages You’ve Read items 4. Tap mark… 5. Tap Mark Read or Mark Unread Observed results: Mark Read/Mark Unread is not functional when selecting items from both categories. Expected results: Mark Read/Mark Unread should be functional when selecting items from both categories. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/1u4O3BnXdAh1rtaGfb3XQPW6EL-HF0iaF/view
,
Jul 10
,
Jul 10
,
Jul 11
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d8362eae96c767c2bda4a6d192e7206666820c1d commit d8362eae96c767c2bda4a6d192e7206666820c1d Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Jul 11 21:48:42 2018 [iOS] Fix |-markSelectedReadingListItemsAfterConfirmation|. Previously, a weak reference to the table view's selected index paths was used in the completion block. Since we end editing before the block is executed, this variable was getting wiped away before the block had a chance to execute. Bug: 862173 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ideb47ea6f9f8bf1d05eed64e657df3b4f09ea989 Reviewed-on: https://chromium-review.googlesource.com/1132431 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574351} [modify] https://crrev.com/d8362eae96c767c2bda4a6d192e7206666820c1d/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Jul 11
,
Jul 17
Verified in: App Version: 69.0.3494.0 canary Devices: iPhone 6 Plus, iPhone X, iPad Mini iOS Versions: 10.3.3, 11.4.1 beta 5 Mark Read/Unread is functional on selecting items from both categories. Video: https://drive.google.com/open?id=1cpBz9WvYfEF1kGklMfl6MfEAZdzdMCI2 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kkhorimoto@chromium.org
, Jul 10