[iOS] Reading List Bug: Pages You’ve Read/ Unread labels animation is messy |
|||||
Issue descriptionApp Version: 69.0.3486.0 canary iOS Version: 11.4.1, 12 Device: iPhone x, iPhone 7, iPad Pro URL: Precondition: Go to: chrome://flags -> Enable #collections-ui-reboot Have an article saved in Reading list Steps to reproduce: 1. Launch Chrome app 2. Go to Reading List -> Edit 3. Select item 4. Tap on Mark Read/mark unread Observed results: Pages You’ve Read/ Unread labels animation is messy Expected results: Pages You’ve Read/ Unread labels animation should be smooth Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image: https://drive.google.com/file/d/14w4mc-DoyJ1xnRHN-D3XqHwO-C2MNPV6/view
,
Jul 10
crrev.com/c/1132420 changes from the fade animation to the default animation. @pschaffner: This isn't included in any mocks, so I'm assuming the "automatic" option is preferable here. Please let me know if you want a different animation style; the list is available here: https://developer.apple.com/documentation/uikit/uitableviewrowanimation?language=objc
,
Jul 11
Automatic sounds like it should be fine to me, Kurt ... thanks for jumping on this. If you get a sec to post a video of what it looks like before landing, that would be great too.
,
Jul 11
,
Jul 11
Here's a screen grab of the automatic animation: https://drive.google.com/open?id=1L4ClNaqyQT7zNIuPbIIsIZS1LUhTolVK
,
Jul 13
Looks like I didn't set up the sharing permissions on the previous link; this should allow you to view: https://drive.google.com/file/d/1L4ClNaqyQT7zNIuPbIIsIZS1LUhTolVK/view?usp=sharing
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73a2b8b674c7c3074fd591e29981f9581e86f7d0 commit 73a2b8b674c7c3074fd591e29981f9581e86f7d0 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Jul 13 22:05:28 2018 [iOS] Use automatic table view row animation for edits. This CL updates the reading list table view edit animations from using UITableViewRowAnimationFade to using UITableViewRowAnimationAutomatic. Bug: 862172 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6cdb098dcf7f454a782adb820b9e0f665a54acb Reviewed-on: https://chromium-review.googlesource.com/1132420 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#575087} [modify] https://crrev.com/73a2b8b674c7c3074fd591e29981f9581e86f7d0/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Jul 13
,
Jul 17
Issue verified Version: Chrome Canary 69.0.3494.0 Device: iPhone 8 iOS: 11.4 Previous reading list table view edit animation https://drive.google.com/open?id=1EldnRWVqCDSBGvtJ65aw6oeR9DRShtbw |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kkhorimoto@chromium.org
, Jul 10