[iOS] Reading List Bug: App crashes when tapping on Mark All Unread |
|||||
Issue descriptionApp Version: 69.0.3486.0 canary iOS Version: 11.4.1, 12 Device: iPhone x, iPhone 7, iPad Pro URL: Precondition: Go to: chrome://flags -> Enable #collections-ui-reboot Have an article saved in Reading list Steps to reproduce: 1. Launch Chrome app 2. Go to Reading List -> Edit -> Mark All… -> Mark All Unread Observed results: App crashes when tapping on Mark All Unread Expected results: App should not crash when tapping on Mark All Unread Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: , Safari: NA Link to video/image https://drive.google.com/file/d/1PVly1epXMG_HiEmDgijIukGeNjcGgNFZ/view Crash log: https://crash.corp.google.com/browse?stbtiq=0dcc5b0de1e36451
,
Jul 11
,
Jul 11
,
Jul 11
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04963cdf8f6d3c4bdf9478d52686871a25fef659 commit 04963cdf8f6d3c4bdf9478d52686871a25fef659 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Jul 11 21:43:26 2018 [iOS] Don't attempt to reset read status for empty sections. If the ReadingListTableViewController's model doesn't have any items in a section, using the "Mark All" option for that section previously threw a DCHECK. This CL early returns so that we don't attempt to access sections that don't exist. Bug: 862169 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iea947d6ef700d5d45afb54961b06e29d77615cd2 Reviewed-on: https://chromium-review.googlesource.com/1132606 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#574347} [modify] https://crrev.com/04963cdf8f6d3c4bdf9478d52686871a25fef659/ios/chrome/browser/ui/reading_list/reading_list_table_view_controller.mm
,
Jul 11
,
Jul 17
Verified in: App Version: 69.0.3494.0 canary Devices: iPhone 6 Plus, iPhone X, iPad Mini iOS Versions: 10.3.3, 11.4.1 beta 5 This crash is not reproducible following the steps mentioned in Comment#0. Video: https://drive.google.com/open?id=1NAJd-JMwCA4DLORMOfssWbi3tOIFJXvk |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kkhorimoto@chromium.org
, Jul 10