New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 862143 link

Starred by 1 user
Status: Fixed
Owner:
fs...@chromium.org
Closed: Jul 10
Cc:
jochen@chromium.org
█ junov@chromium.org
fs...@chromium.org
foolip@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 0
Type: Bug

Blocking:
issue 862161



Sign in to add a comment

stable webexposed missing enabled features

Project Member Reported by fs...@chromium.org, Jul 10 
I don't know if I'm doing something wrong, but here's the problem:

This CL makes OffscreenCanvas runtime stable:
https://chromium-review.googlesource.com/c/chromium/src/+/1119156

This flag is used, for example, at:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.idl?q=offscreen_Canvas.idl&sq=package:chromium&dr

The webexposed tests trigger correctly for Workers, as can be seen on the CL, but it seems that the stable interface didn't get updated for Window, even thought now Chrome does exposes this on stable (as far as I can test).

If I check on third_party/WebKit/LayoutTests/virtual/stable/webexposed, the only mentions of OffscreenCanvas are on Workers listing, even though the interface is clearly available on Window.

This may be a big issue, if other features have been approved on stable without API_OWNERS permission, since AFAIK this is the mechanism we use to control features going to stable.

Comment 1 by fs...@chromium.org, Jul 10

Cc: fs...@chromium.org
Labels: -Pri-1 Pri-0
Owner: fs...@chromium.org
Status: Assigned (was: Untriaged)
I'm escalating this to P0, and assigning to myself since I don't know who on FeatureControl could help with that. (Anyone on feature control, feel free to take over).

It seems that this sheriff CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1090837
disabled stable/webexpectations a month ago.

I'm sending a CL to reenable it.

Comment 2 by fs...@chromium.org, Jul 10

Blocking: 862161
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98b656da3236cb97b12fde958b34286c23900b37

commit 98b656da3236cb97b12fde958b34286c23900b37
Author: Fernando Serboncini <fserb@chromium.org>
Date: Tue Jul 10 15:32:23 2018

Reenable stable/webexposed/global-interface-listing

The exposed diff is all due to OffscreenCanvas, that
was enabled a week ago.

Bug:  862143 
Change-Id: I0fdcf3ea54386d1255d181ec5cf0d44e3200ed80
Reviewed-on: https://chromium-review.googlesource.com/1131231
Reviewed-by: Jason Chase <chasej@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573742}
[modify] https://crrev.com/98b656da3236cb97b12fde958b34286c23900b37/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/98b656da3236cb97b12fde958b34286c23900b37/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt

Comment 4 by fs...@chromium.org, Jul 10

Status: Fixed (was: Assigned)
This is fixed.
The expected diff was just OffscreenCanvas.

Moving to the next bug which should prevent stable/webexposed from being marked as anything.

Comment 5 by foolip@chromium.org, Jul 10 

Excellent, thanks for the speedy fix!
►

Sign in to add a comment