New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 862096 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup/refresh set of stories disabled on all platforms

Project Member Reported by perezju@chromium.org, Jul 10

Issue description

The story has been disabled for a while (possibly tagged with the wrong bug number), and it no longer works when run with --also-run-disabled as it just sits on page telling the user that flash is required for pandora to work.

Should the story just be removed?
 
Cc: charliea@chromium.org tdres...@chromium.org sullivan@chromium.org
Yes. I think we should remove all the story with Disabled All & have a backlog to revive them
tdresser: any opinions? I think it might be good to do a lightweight check if things work locally/work in pinpoint perf try jobs before disabling, but Juan has already checked that the page in question doesn't work in this case.
For this specific example, it sounds like the story should be removed.

In general, I think it might make sense to set up a few hours to get everyone in a VC, and collaboratively go through identifying which 'Disabled All' stories should be removed, and which should be turned back on.

Once we've put in some effort, Ned's proposal SGTM. 

Does that sound reasonable?
Yeah, that sounds good. Sharding the work of locally running/pinpoint testing the failing stories would be good for ramping everyone up a little :)
I'll take an AI to plan this, ensuring folks like Ned can show up.

For now, I think removing this story in particular makes sense though.
Agree with the current consensus. Proceeding to remove this story for now. :) 
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bb8bedc89fe935db77b90344c240e8e4617725c

commit 2bb8bedc89fe935db77b90344c240e8e4617725c
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Jul 10 17:21:16 2018

[tools/perf] Remove play:media:pandora user story

Story no longer works due to flash requirements.

Also updated system_health_stories.csv

Bug: 862096
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Ie44f249607147585ec90b2ea71f4864c816bd1a7
Reviewed-on: https://chromium-review.googlesource.com/1131496
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573787}
[modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/core/generate_system_health_csv_unittest.py
[modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/expectations.config
[delete] https://crrev.com/421037353f2e5b63fc59c49772407d7492ec76a7/tools/perf/page_sets/login_helpers/pandora_login.py
[modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/page_sets/system_health/media_stories.py
[modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/system_health_stories.csv

Summary: Cleanup/refresh set of stories disabled on all platforms (was: play:media:pandora story no longer works)
Owner: tdres...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Tim for now as per #5.

Comment 10 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 11 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment