Cleanup/refresh set of stories disabled on all platforms |
|||||
Issue descriptionThe story has been disabled for a while (possibly tagged with the wrong bug number), and it no longer works when run with --also-run-disabled as it just sits on page telling the user that flash is required for pandora to work. Should the story just be removed?
,
Jul 10
tdresser: any opinions? I think it might be good to do a lightweight check if things work locally/work in pinpoint perf try jobs before disabling, but Juan has already checked that the page in question doesn't work in this case.
,
Jul 10
For this specific example, it sounds like the story should be removed. In general, I think it might make sense to set up a few hours to get everyone in a VC, and collaboratively go through identifying which 'Disabled All' stories should be removed, and which should be turned back on. Once we've put in some effort, Ned's proposal SGTM. Does that sound reasonable?
,
Jul 10
Yeah, that sounds good. Sharding the work of locally running/pinpoint testing the failing stories would be good for ramping everyone up a little :)
,
Jul 10
I'll take an AI to plan this, ensuring folks like Ned can show up. For now, I think removing this story in particular makes sense though.
,
Jul 10
Agree with the current consensus. Proceeding to remove this story for now. :)
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bb8bedc89fe935db77b90344c240e8e4617725c commit 2bb8bedc89fe935db77b90344c240e8e4617725c Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Jul 10 17:21:16 2018 [tools/perf] Remove play:media:pandora user story Story no longer works due to flash requirements. Also updated system_health_stories.csv Bug: 862096 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ie44f249607147585ec90b2ea71f4864c816bd1a7 Reviewed-on: https://chromium-review.googlesource.com/1131496 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#573787} [modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/core/generate_system_health_csv_unittest.py [modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/expectations.config [delete] https://crrev.com/421037353f2e5b63fc59c49772407d7492ec76a7/tools/perf/page_sets/login_helpers/pandora_login.py [modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/page_sets/system_health/media_stories.py [modify] https://crrev.com/2bb8bedc89fe935db77b90344c240e8e4617725c/tools/perf/system_health_stories.csv
,
Jul 11
,
Jul 11
Assigning to Tim for now as per #5.
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nednguyen@chromium.org
, Jul 10