Skip login during benchmark story replay |
|||||
Issue descriptionThe login flow should only be included in record mode, but skipped during replay mode.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a798b495c6aedd555caefa79b226d45b5ea38bb commit 7a798b495c6aedd555caefa79b226d45b5ea38bb Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Jul 10 12:02:09 2018 [tools/perf] Skip login flow in system health stories During replay we do not want to run the login flow to a web site, this is only really relevant to get a recording. This change causes the login flow to be skipped for most stories, except a couple of them where removing the flow would cause the current recordings to break. Bug: 857483 Bug: 862077 Change-Id: I1f1f091420f3e6e9735f7166b3d3e9f1e40415fb Reviewed-on: https://chromium-review.googlesource.com/1131114 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#573686} [modify] https://crrev.com/7a798b495c6aedd555caefa79b226d45b5ea38bb/tools/perf/page_sets/system_health/loading_stories.py [modify] https://crrev.com/7a798b495c6aedd555caefa79b226d45b5ea38bb/tools/perf/page_sets/system_health/long_running_stories.py [modify] https://crrev.com/7a798b495c6aedd555caefa79b226d45b5ea38bb/tools/perf/page_sets/system_health/system_health_story.py
,
Jul 11
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0be8c5963df44ccfb0270708b3683ccb60a322d2 commit 0be8c5963df44ccfb0270708b3683ccb60a322d2 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Tue Aug 21 16:49:01 2018 Add story property: wpr_mode Example usage: skipping the login flow in wpr replay mode. Bug: chromium:862077 Change-Id: Iae6bb2db1521fc678ce57b0c03b54c0e58dfeee6 Reviewed-on: https://chromium-review.googlesource.com/1172277 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Vovo Yang <vovoy@chromium.org> [add] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/story/shared_state_unittest.py [modify] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/story/story.py [modify] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/story/shared_state.py [modify] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/internal/story_runner.py [modify] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/page/shared_page_state.py [modify] https://crrev.com/0be8c5963df44ccfb0270708b3683ccb60a322d2/telemetry/telemetry/internal/story_runner_unittest.py
,
Aug 21
,
Aug 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcc387a51abaa21aa580d1703ff431c1356c07b4 commit bcc387a51abaa21aa580d1703ff431c1356c07b4 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Aug 22 17:46:38 2018 Roll src/third_party/catapult ba76717a8d18..bbb04a38bbdb (23 commits) https://chromium.googlesource.com/catapult.git/+log/ba76717a8d18..bbb04a38bbdb git log ba76717a8d18..bbb04a38bbdb --date=short --no-merges --format='%ad %ae %s' 2018-08-22 wangge@google.com Fix Bug When No APK is present and Add Relevant Test Cases. 2018-08-22 anthonyalridge@google.com Initial application of mann whitney testing. 2018-08-22 benjhayden@chromium.org [chromeperf v2] Simple redux helpers. 2018-08-22 benjhayden@chromium.org Add icons for V2SPA. 2018-08-21 mseaborn@google.com [dashboard] Update docs to mention old issues filed in the Github tracker 2018-08-21 benjhayden@chromium.org Fix minify script for v2spa. 2018-08-21 benjhayden@chromium.org Add some utility functions to V2SPA. 2018-08-21 eakuefner@chromium.org [Tracing] Fix Pylint errors 2018-08-21 amyqiu@google.com Fix search bug in metrics visualization tool 2018-08-21 benjhayden@chromium.org Add ElementBase for V2SPA. 2018-08-21 benjhayden@chromium.org Plumb test case tag maps via test suite descriptors. 2018-08-21 vovoy@chromium.org Add story property: wpr_mode 2018-08-21 wangge@google.com Restructure Long Term Health Tool Output File Structure. 2018-08-20 benjhayden@chromium.org Add Material textarea for V2SPA. 2018-08-20 benjhayden@chromium.org Add checkbox to V2SPA. 2018-08-20 benjhayden@chromium.org Add cp-loading for V2SPA. 2018-08-20 benjhayden@chromium.org Add raised-button to V2SPA. 2018-08-20 chiniforooshan@chromium.org Telemetry: pixel metrics in TBMv2 2018-08-20 simonhatch@chromium.org Dashboard - Add a path for inserting out-of-order diagnostics. 2018-08-20 simonhatch@chromium.org Dashboard - Fix gcs read. 2018-08-20 chiniforooshan@chromium.org Telemetry: rename metrics as per crbug.com/627461 2018-08-20 simonhatch@chromium.org Dashboard - Cleanup unused masters and bots 2018-08-20 chiniforooshan@chromium.org Telemetry: break rendering_metric.html Created with: gclient setdep -r src/third_party/catapult@bbb04a38bbdb The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:863390 ,chromium:866423,chromium:862077, chromium:863390 ,chromium:760553, chromium:874856 , chromium:627461 ,chromium:760553 TBR=sullivan@chromium.org Change-Id: I6f9a52e2e301d0e04b4800a9c57a33000ec51f26 Reviewed-on: https://chromium-review.googlesource.com/1185141 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585147} [modify] https://crrev.com/bcc387a51abaa21aa580d1703ff431c1356c07b4/DEPS
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbf0f2f517312568dfbb417c6be7420ba1c68f81 commit dbf0f2f517312568dfbb417c6be7420ba1c68f81 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Thu Aug 23 02:24:07 2018 Skip login flow when replaying top_real_world_desktop pages **SHERIFFS** this test only CL may cause regression but it's expected. Bug: chromium:862077 Bug: chromium:873081 Change-Id: Ia8c338b6e87fec576f3b5573ecfd1c2d824f2836 Reviewed-on: https://chromium-review.googlesource.com/1184733 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585371} [modify] https://crrev.com/dbf0f2f517312568dfbb417c6be7420ba1c68f81/tools/perf/page_sets/rendering/top_real_world_desktop.py
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by nednguyen@chromium.org
, Jul 10