New issue
Advanced search Search tips

Issue 862075 link

Starred by 1 user
Status: Assigned
Owner:
rhalavati@chromium.org
Cc:
rdevlin....@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Audit and add tests for compliance of Extensions API with Incognito Expectations.

Project Member Reported by rhalavati@chromium.org, Jul 10 
It is expected that:
 - If an extension is not allowed in incognito mode, it will not have any effect in incognito.
 - If an extension is allowed in incognito and changes a Chrome setting or user preference in incognito, the change will not affect the regular mode and is reset if extension’s permission to run in incognito is revoked.

Extension APIs should be checked for these issues and appropriate tests should be added to prevent future regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a48702213a412bfabbac02a8a8bc894a4976d7ff

commit a48702213a412bfabbac02a8a8bc894a4976d7ff
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Jul 31 05:41:04 2018

Test Extensions incognito permission is respected by key binding.

A test is added to check if an extension with command key binding can
not be accessed when it is not allowed in incognito.

Bug: 862075
Change-Id: Id49fb16958a9913978f8b054740c0ef4d0977c25
Reviewed-on: https://chromium-review.googlesource.com/1141727
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579320}
[modify] https://crrev.com/a48702213a412bfabbac02a8a8bc894a4976d7ff/chrome/browser/extensions/extension_keybinding_apitest.cc
[modify] https://crrev.com/a48702213a412bfabbac02a8a8bc894a4976d7ff/extensions/browser/event_router.cc
[modify] https://crrev.com/a48702213a412bfabbac02a8a8bc894a4976d7ff/extensions/browser/event_router.h
[modify] https://crrev.com/a48702213a412bfabbac02a8a8bc894a4976d7ff/extensions/browser/test_event_router_observer.cc
[modify] https://crrev.com/a48702213a412bfabbac02a8a8bc894a4976d7ff/extensions/browser/test_event_router_observer.h
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e2a1afa5e5db5c80e1a10f61086928dd1b493ef

commit 1e2a1afa5e5db5c80e1a10f61086928dd1b493ef
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Aug 13 07:05:58 2018

Add incognito mode tests for Extensions Tabs API.

Tests are added to Extensions Tabs API to ensure extensions cannot
create or query the tabs in incognito mode when they are not enabled
to run there.

Bug: 862075
Change-Id: I6081b4cc432c82d147a65f30311af0708efe03f9
Reviewed-on: https://chromium-review.googlesource.com/1158368
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582514}
[modify] https://crrev.com/1e2a1afa5e5db5c80e1a10f61086928dd1b493ef/chrome/browser/extensions/extension_tabs_apitest.cc
[add] https://crrev.com/1e2a1afa5e5db5c80e1a10f61086928dd1b493ef/chrome/test/data/extensions/api_test/tabs/basics/incognito.html
[add] https://crrev.com/1e2a1afa5e5db5c80e1a10f61086928dd1b493ef/chrome/test/data/extensions/api_test/tabs/basics/incognito.js
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc

commit 075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Sep 27 09:30:24 2018

Add incognito test to Extensions History API.

Checks if an extension with access to history API and incognito mode
can modify regular mode history if it is used from incognito.

Bug: 862075
Change-Id: I4964ff94db19cdacdbfd3e57e8414b95f837519f
Reviewed-on: https://chromium-review.googlesource.com/1188564
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594643}
[modify] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/browser/extensions/api/history/history_apitest.cc
[add] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/incognito/incognito.js
[add] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/incognito/manifest.json
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/a.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/b.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/common.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/delete.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/delete.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/delete_prohibited.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/delete_prohibited.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/get_visits.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/get_visits.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/manifest.json
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/misc_search.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/misc_search.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/search_after_add.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/search_after_add.js
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/timed_search.html
[rename] https://crrev.com/075ebf2b0a7352b81ca80fc4e8e8986f4a7369fc/chrome/test/data/extensions/api_test/history/regular/timed_search.js
►

Sign in to add a comment