Issue metadata
Sign in to add a comment
|
CSS zoom breaks video controls
Reported by
hakim.el...@gmail.com,
Jul 10
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36 Steps to reproduce the problem: 1. Set the CSS `zoom` property to 2 on a <video> node or any of its parent nodes 2. Try to click the play button (or any other video control) What is the expected behavior? The video should start playing What went wrong? Nothing happens. The video control hit areas are in the original non-zoomed location. They don't align with the zoomed 2x scale. Did this work before? Yes Chrome 66 Does this work in other browsers? Yes Chrome version: 67.0.3396.99 Channel: stable OS Version: OS X 10.13.5 Flash Version: Can be reproduced with: <video style="zoom: 2;" src="http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4" controls></video> Try it here in Chrome 67: https://codepen.io/hakimel/full/rrNxba
,
Jul 10
,
Jul 11
hakim.elhattab@ Thanks for the issue. Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 14.04 on the latest Stable 67.0.3396.99, Beta 68.0.3440.42 and latest Canary 69.0.3487.0 as per the original comment. Bisect Information: =================== Good Build: 67.0.3396.3 Bad Build : 67.0.3396.7 As this is regressed in branch builds, unable to run the per-revision bisect script. Hence below is the manual changelog URL from omahaproxy. https://chromium.googlesource.com/chromium/src/+log/67.0.3396.3..67.0.3396.7?pretty=fuller&n=10000 From the above Changelog, suspecting the below change: Reviewed-on: https://chromium-review.googlesource.com/993757 beccahughes@ Please check and confirm if this issue is related to your change, else help us in assigning to the right owner. Adding 'ReleaseBlock-Stable' for M-68 as this is a recent regression. Please feel free to remove it if it is not applicable. Thanks
,
Jul 11
This is unlikely to be that CL as we actually switch over to a whole new set of media controls in that bisect range.
,
Jul 11
,
Jul 11
We're not planning any further M67 release. Pls target fix for M68.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e77d802b9cc8260ffa944a23254eabac3fc874a commit 6e77d802b9cc8260ffa944a23254eabac3fc874a Author: Tommy Steimel <steimel@chromium.org> Date: Fri Jul 13 20:24:12 2018 [Media Controls] Use zoom when calculating overlay play button hitbox This CL modifies the overlay play button ShouldCausePlayPause function to take CSS and Document zoom into account. This fixes a bug where a zoomed video had an incorrect hitbox for the overlay play button. Bug: 862063 Change-Id: I3f51454618e5c455bba62b4b019701d67fd8886c Reviewed-on: https://chromium-review.googlesource.com/1135663 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575051} [modify] https://crrev.com/6e77d802b9cc8260ffa944a23254eabac3fc874a/third_party/WebKit/LayoutTests/media/video-controls-zoomed.html [modify] https://crrev.com/6e77d802b9cc8260ffa944a23254eabac3fc874a/third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
,
Jul 16
Seems like this just landed on Friday. Has this been verified in canary yet? Once verified, is this safe enough to be merged to M68?
,
Jul 17
Chatted with steimel@, fix will be targeted for M69.
,
Jul 27
Able to reproduce this issue on Windows 10, Ubuntu 16.04 and Mac OS 10.13.3 on the reported version 67.0.3396.99 and the issue is fixed on the latest Canary 70.0.3504.0 as per the original comment. Able to click on the play button and the video starts playing. Attached is the screen cast for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jul 31
As it is WAI on M70, please merge the fix to M69 if it is safe to merge. Thanks..!
,
Jul 31
The fix should be in 69.0.3493.3. I will leave this open and let steimel@ confirms that there is nothing more to be done here when he is back.
,
Aug 7
M69 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Aug 8
I've fixed the overlay play button issue, which was RBS, but there's a remaining issue with the overflow menu positioning. However, that is already stable in M68, so it's not a RBS. Therefore, removing the RBS label
,
Aug 30
FYI we're pulling the fix for the overlay play button since it's causing crashes. I have another solution that requires a significant refactoring so this won't be fixed in M69
,
Oct 15
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Jul 10