New issue
Advanced search Search tips

Issue 861996 link

Starred by 1 user
Status: Fixed
Owner:
ftirelo@chromium.org
Closed: Jul 18
Cc:
ftirelo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[Autofill dropdown revamp] Dropdown row hovering highlight remains even when the mouse is out of the row/dropdown

Project Member Reported by ftirelo@chromium.org, Jul 10 
Chrome Version: M69
OS: desktop

What steps will reproduce the problem?
(1) Navigate to chrome://settings/autofill and add an address
(2) Navigate to https://rsolomakhin.github.io/autofill/
(3) Scroll all way up and click on the "Name" field in the "Profile Autofill" section and hover on a suggestion to select it.
(4) Move the mouse out of the dropdown without clicking anywhere

What is the expected result?

The current suggestion should be deselected.

What happens instead?

It's not.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0948203dfbd257a4f84b414602228d64bc8c2894

commit 0948203dfbd257a4f84b414602228d64bc8c2894
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Mon Jul 16 23:12:40 2018

[AF] Deselect current row if mouse leaves the dropdown

Bug:  861996 
Change-Id: Ie3d579b3d59ba230ceec5229b2aebb3921deeda2
Reviewed-on: https://chromium-review.googlesource.com/1138801
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575469}
[modify] https://crrev.com/0948203dfbd257a4f84b414602228d64bc8c2894/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Comment 2 by ftirelo@chromium.org, Jul 16

Owner: ftirelo@chromium.org
Status: Fixed (was: Untriaged)

Comment 3 by ftirelo@chromium.org, Jul 18

Status: Assigned (was: Fixed)
Reopening, because it's not fully fixed. Now we unselect the suggestion when we hover on the icon on the description.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36fa5b4c741e453bb3bec89dde72f6a4beb1504c

commit 36fa5b4c741e453bb3bec89dde72f6a4beb1504c
Author: Fabio Tirelo <ftirelo@chromium.org>
Date: Wed Jul 18 18:20:27 2018

[AF] Notify row on mouse events on child views

The current implementation considers that a hover on the label or the
icon corresponds to a mouse exit event for the row, leading to the
current row being deselected. This CL fixes that by notifying the row
view on mouse enter/exit on child events as well.

Bug:  861996 
Change-Id: If187048b2893afb7c779f91010b7b225d0da49d7
Reviewed-on: https://chromium-review.googlesource.com/1142035
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576142}
[modify] https://crrev.com/36fa5b4c741e453bb3bec89dde72f6a4beb1504c/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc

Comment 5 by ftirelo@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment