New issue
Advanced search Search tips

Issue 861973 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

confirm_or_exit() in git_cl.py no longer catch ctrl-c

Project Member Reported by wychen@chromium.org, Jul 9

Issue description

Chrome Version: chromium/tools/depot_tools revision 92745a5b0e2e7593fabe8b831cb913cd548b257b
OS: Linux

What steps will reproduce the problem?
(1) Do anything that'd trigger a confirm_or_exit(), for example, "git cl land" a Gerrit CL for Chromium, the following message should be printed:

It seems this repository has a Commit Queue, which can test and land changes for you. Are you sure you wish to bypass it?
Press Enter to bypass CQ, or Ctrl+C to abort

(2) Do Ctrl-C to abort

What is the expected result?
"git cl" should abort.

What happens instead?
Nothing happens.

 
Components: -Infra Infra>SDK

Sign in to add a comment