New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 861967 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ARC++ frame may not fully drawn when dragging from low dpi to high dpi

Project Member Reported by osh...@chromium.org, Jul 9

Issue description

Repro step: connect external display to high DPI device,
and drag arc ++ window from external to internal.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4596251cd724b6b2769537558c5fdb3d7f16c413

commit 4596251cd724b6b2769537558c5fdb3d7f16c413
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Jul 10 00:20:09 2018

Adjust frame pixel width in phantom window

Since the width is given in pixels which is correct
only on the display with the same DSF, the width needs to
be multiplied by phanton window scale / source scale.

BUG= 861967 
TEST=Manual. See bug for repro step.

Change-Id: Ib073bb705d8998cf07f41f9d646f0c23828b48de
Reviewed-on: https://chromium-review.googlesource.com/1130595
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573550}
[modify] https://crrev.com/4596251cd724b6b2769537558c5fdb3d7f16c413/ash/frame/default_frame_header.cc

Labels: Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 10

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: bhthompson@chromium.org
The change is small and risk is low.
Tested on ToT / 69?  We need to test for the change and ensure no unanticipated impact.  Thanks,
Yes, it's tested on ToT.

Chrome hasn't been upreved nearly 2 weeks due to infra issue, so it's not tested by canary tho.
Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 16

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/436c6fa481b85fbabdf65e6ffb3a91cdb8219995

commit 436c6fa481b85fbabdf65e6ffb3a91cdb8219995
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Jul 16 22:24:14 2018

Adjust frame pixel width in phantom window

Since the width is given in pixels which is correct
only on the display with the same DSF, the width needs to
be multiplied by phanton window scale / source scale.

BUG= 861967 
TEST=Manual. See bug for repro step.

Change-Id: Ib073bb705d8998cf07f41f9d646f0c23828b48de
Reviewed-on: https://chromium-review.googlesource.com/1130595
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#573550}(cherry picked from commit 4596251cd724b6b2769537558c5fdb3d7f16c413)
Reviewed-on: https://chromium-review.googlesource.com/1138895
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#685}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/436c6fa481b85fbabdf65e6ffb3a91cdb8219995/ash/frame/default_frame_header.cc

Status: Fixed (was: Started)

Sign in to add a comment