New issue
Advanced search Search tips

Issue 861953 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

DCHECK failure in (token.literal_chars) != nullptr in scanner.cc

Project Member Reported by ClusterFuzz, Jul 9

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6054193698439168

Fuzzer: libFuzzer_v8_fully_instrumented_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  (token.literal_chars) != nullptr in scanner.cc
  v8::internal::Scanner::SanityCheckTokenDesc
  v8::internal::Scanner::Scan
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572608:573021

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6054193698439168

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 9

Components: Blink>JavaScript>Parser
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 9

Cc: metzman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jul 9

Labels: Test-Predator-Auto-Owner
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/v8/v8/+/02b6178cef33b6bba5949af4ea2fd2c8bad9de74 ([scanner] Push surrogate pair handling down into identifier scanning).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 10

Labels: M-69 Target-69
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 10

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 10

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0ff83e97997c38609898af7a6ed11bca0ece1a0d

commit 0ff83e97997c38609898af7a6ed11bca0ece1a0d
Author: Toon Verwaest <verwaest@chromium.org>
Date: Fri Jul 20 10:00:25 2018

[scanner] Always complete literals for possibly escaped FUTURE_STRICT_RESERVED_WORD

Bug:  chromium:861953 
Change-Id: Id3a57aca0b24c421ac959d69265c449eaa214c16
Reviewed-on: https://chromium-review.googlesource.com/1138083
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54573}
[modify] https://crrev.com/0ff83e97997c38609898af7a6ed11bca0ece1a0d/src/parsing/scanner.cc

Project Member

Comment 8 by ClusterFuzz, Jul 21

ClusterFuzz has detected this issue as fixed in range 576997:577000.

Detailed report: https://clusterfuzz.com/testcase?key=6054193698439168

Fuzzer: libFuzzer_v8_fully_instrumented_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  (token.literal_chars) != nullptr in scanner.cc
  v8::internal::Scanner::SanityCheckTokenDesc
  v8::internal::Scanner::Scan
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572608:573021
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=576997:577000

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6054193698439168

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jul 21

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6054193698439168 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 21

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-69
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 16

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org hablich@chromium.org
+ awhalley@ (Security TPM) for M69 merge review
govind@ - good for 69
Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #14. Please merge ASAP. Thank you.
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 20

Labels: merge-merged-6.9
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/df22ea0a09b9818898b98244ccbc3cd1c2d55334

commit df22ea0a09b9818898b98244ccbc3cd1c2d55334
Author: Toon Verwaest <verwaest@chromium.org>
Date: Mon Aug 20 16:01:58 2018

Merged: [scanner] Always complete literals for possibly escaped FUTURE_STRICT_RESERVED_WORD

Revision: 0ff83e97997c38609898af7a6ed11bca0ece1a0d

BUG= chromium:861953 
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=ishell@chromium.org

Change-Id: Ib315116923c1c488ef71f9dc079fa5c68f342dc9
Reviewed-on: https://chromium-review.googlesource.com/1181424
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.9@{#31}
Cr-Branched-From: d7b61abe7b48928aed739f02bf7695732d359e7e-refs/heads/6.9.427@{#1}
Cr-Branched-From: b7e108d6016bf6b7de3a34e6d61cb522f5193460-refs/heads/master@{#54504}
[modify] https://crrev.com/df22ea0a09b9818898b98244ccbc3cd1c2d55334/src/parsing/scanner.cc

Project Member

Comment 17 by sheriffbot@chromium.org, Aug 20

Cc: awhalley@google.com gov...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-69
Labels: -ReleaseBlock-Stable
Project Member

Comment 20 by sheriffbot@chromium.org, Oct 27

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment