New issue
Advanced search Search tips

Issue 861923 link

Starred by 1 user
Status: Fixed
Owner:
oksamyt@chromium.org
Closed: Jul 31
Cc:
reillyg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Remove device::MotionData and device::OrientationData

Project Member Reported by oksamyt@chromium.org, Jul 9 
Since device::MotionData and device::OrientationData are not used in //content and //device, they can be moved to blink (//third_party/blink/renderer/modules/device_orientation).
The references in layouttest_support (https://cs.chromium.org/chromium/src/content/test/layouttest_support.cc?g=0&l=77) seem to be unused so they can be removed.

Comment 1 by reillyg@chromium.org, Jul 9

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
It may even be possible to remove these classes entirely as blink::DeviceOrientationData and blink::DeviceMotionData store roughly the same information.

Comment 2 by reillyg@chromium.org, Jul 11

Labels: -Type-Bug Type-Task
Owner: oksamyt@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by oksamyt@chromium.org, Jul 11

Description: Show this description

Comment 4 by oksamyt@chromium.org, Jul 11

Summary: Move device::MotionData and device::OrientationData to blink (was: Move DeviceMotionData and DeviceOrientationData to blink)

Comment 5 by oksamyt@chromium.org, Jul 12

Status: Started (was: Assigned)

Comment 6 by oksamyt@chromium.org, Jul 16

Summary: Remove device::MotionData and device::OrientationData (was: Move device::MotionData and device::OrientationData to blink)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e60cd866715c285714cce1e00d4fe211f4db42fe

commit e60cd866715c285714cce1e00d4fe211f4db42fe
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Thu Jul 19 01:24:16 2018

Replace usages of device::MotionData with DeviceMotionData

Since DeviceMotionData class has all the information from
device::MotionData, and DeviceMotionEventPump is now in blink,
DeviceMotionData is now passed to DeviceMotionDispatcher.
device::MotionData will be removed in a subsequent change.

Bug:  861923 
Change-Id: I1165d1dbd128197e2e00d7ad63db17d03e6af810
Reviewed-on: https://chromium-review.googlesource.com/1137171
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576301}
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/public/platform/modules/device_orientation/web_device_motion_listener.h
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/DEPS
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_data.cc
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_data.h
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.cc
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_dispatcher.h
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.cc
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump.h
[modify] https://crrev.com/e60cd866715c285714cce1e00d4fe211f4db42fe/third_party/blink/renderer/modules/device_orientation/device_motion_event_pump_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c64076d90369afd6b2a600e1b7d2efbe44f29b0

commit 8c64076d90369afd6b2a600e1b7d2efbe44f29b0
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Wed Jul 25 18:31:18 2018

Replace usages of device::OrientationData with DeviceOrientationData

Since DeviceOrientationData class has all the information from
device::OrientationData, and DeviceOrientationEventPump is now in blink,
DeviceOrientationData is now passed to DeviceOrientationDispatcher.
device::OrientationData will be removed in a subsequent change.

Bug:  861923 
Change-Id: If1cb812502f85dd46011398a54f45bba2353044d
Reviewed-on: https://chromium-review.googlesource.com/1142459
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577985}
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/public/platform/modules/device_orientation/web_device_orientation_listener.h
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/DEPS
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_data.cc
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_data.h
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.cc
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_dispatcher.h
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.cc
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump.h
[modify] https://crrev.com/8c64076d90369afd6b2a600e1b7d2efbe44f29b0/third_party/blink/renderer/modules/device_orientation/device_orientation_event_pump_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1b87dada38c5555d81a55ceade4baad4600bb38

commit f1b87dada38c5555d81a55ceade4baad4600bb38
Author: Oksana Zhuravlova <oksamyt@chromium.org>
Date: Fri Jul 27 01:40:24 2018

Remove unused device::MotionData and device::OrientationData

Bug:  861923 
Change-Id: If70fbe3e56d9e6e11841bf694fb45041fdcc7a38
Reviewed-on: https://chromium-review.googlesource.com/1150624
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578510}
[modify] https://crrev.com/f1b87dada38c5555d81a55ceade4baad4600bb38/content/shell/test_runner/BUILD.gn
[modify] https://crrev.com/f1b87dada38c5555d81a55ceade4baad4600bb38/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/f1b87dada38c5555d81a55ceade4baad4600bb38/content/test/layouttest_support.cc
[modify] https://crrev.com/f1b87dada38c5555d81a55ceade4baad4600bb38/services/device/public/cpp/generic_sensor/BUILD.gn
[delete] https://crrev.com/696fb33bfb93ed9b759fa06aea81d26beedb4872/services/device/public/cpp/generic_sensor/motion_data.cc
[delete] https://crrev.com/696fb33bfb93ed9b759fa06aea81d26beedb4872/services/device/public/cpp/generic_sensor/motion_data.h
[delete] https://crrev.com/696fb33bfb93ed9b759fa06aea81d26beedb4872/services/device/public/cpp/generic_sensor/orientation_data.cc
[delete] https://crrev.com/696fb33bfb93ed9b759fa06aea81d26beedb4872/services/device/public/cpp/generic_sensor/orientation_data.h
[modify] https://crrev.com/f1b87dada38c5555d81a55ceade4baad4600bb38/third_party/blink/renderer/modules/device_orientation/BUILD.gn

Comment 10 by oksamyt@chromium.org, Jul 31

Status: Fixed (was: Started)
►

Sign in to add a comment